search

henninghall / react-native-date-picker

React Native Date Picker is datetime picker for Android and iOS. It includes date, time and datetime picker modes. The datepicker is customizable and is supporting different languages. It's written with native code to achieve the best possible look, feel and performance.
MIT License
2.25k stars 346 forks source link

Done add prop dividerColor for android #732

Closed dumihi313 closed 8 months ago

dumihi313 commented 11 months ago

I added a prop for the divider color. Would you mind spending some time for review?

Initially, I expect to set transparent for the divider color. But some logic on colorToHex.js does not allow me. So, to achieve make the divider hidden, I changed to make the same color of the divider (white) same with the background color date picker to make it feel hidden

henninghall commented 8 months ago

Thanks for the PR, divider color prop now exists since v5, so this change is no longer needed.

TrustDec commented 6 months ago

Thanks for the PR, divider color prop now exists since v5, so this change is no longer needed.

I don't understand what you mean. dividerColor still does not support setting transparent in the latest version.