search

henninghall / react-native-date-picker

React Native Date Picker is datetime picker for Android and iOS. It includes date, time and datetime picker modes. The datepicker is customizable and is supporting different languages. It's written with native code to achieve the best possible look, feel and performance.
MIT License
2.21k stars 338 forks source link

title text in dark mode under Android is too dark to be legible and the color is not manually configurable #829

Closed rubenjavier closed 1 month ago

rubenjavier commented 3 months ago

Describe the bug The title text in dark mode under Android is too dark to be legible and the color is not manually configurable

Expected behavior The title text should be legible in dark theme or better yet, the title text color and modal background color should be configurable ideally we should have the following colors to be configurable titleColor backgroundColor

Thanks in advance.

To Reproduce set theme to dark in android 14

Smartphone (please complete the following information):

Georg7 commented 3 months ago

Same issue here. Only on Android (modal mode) IMG_1613

mkhoussid commented 2 months ago

Is this library no longer maintained? Many issues opened regarding dark mode

henninghall commented 1 month ago

Fixed in v5.0.6

Georg7 commented 1 month ago

Fixed in v5.0.6

I've just upgraded to v5.0.7 but still having the same issue. What's worse the action buttons are now also not adapting to dark mode anymore.

IMG_2194

<DatePicker date={date} onDateChange={setDate} mode="time" modal={true} confirmText={t("common.actions.confirm")} cancelText={t("common.actions.cancel")} title={t("common.actions.selectTime")} locale={i18n.language} open={pickerOpen} textColor={Colors[colorScheme].primary} theme={"dark"} dividerColor={Colors[colorScheme].secondary[100]} minuteInterval={15} onConfirm={handlePickerConfirm} onCancel={() => setPickerOpen(false)} />

henninghall commented 1 month ago

@Georg7 Did you rebuild the app? What android version are you using?

Georg7 commented 4 weeks ago

@Georg7 Did you rebuild the app? What android version are you using?

Yes, rebuilt the app. Title works correctly but action buttons in dark mode still don't work (black colour on dark background). Android 13.

ericpoulinnz commented 2 weeks ago

@henninghall any update here? This also happens for me on version 5.0.7.

The Divider seems to adapt to the theme color, but the title and buttons do not.

Edit: I am using a Google Pixel 6 with Android 14 and React Native 74.5