search

henninghall / react-native-date-picker

React Native Date Picker is datetime picker for Android and iOS. It includes date, time and datetime picker modes. The datepicker is customizable and is supporting different languages. It's written with native code to achieve the best possible look, feel and performance.
MIT License
2.21k stars 338 forks source link

fix: Resolve Attribute issue causing Android Build to fail #853

Closed lil-sahil closed 1 month ago

lil-sahil commented 1 month ago

"Fix resolveAttribute issue in DatePickerModuleImpl.java

Updated the line resolving the 'dialogPreferredPadding' attribute to include the 'android' prefix. This change corrects an error where the attribute could not be found, causing the build to fail on Android.

Previous: theme.resolveAttribute(R.attr.dialogPreferredPadding, typedValue, true);

Updated: theme.resolveAttribute(android.R.attr.dialogPreferredPadding, typedValue, true);

This fix ensures that the correct system attribute is referenced, preventing the build failure."

henninghall commented 1 month ago

@lil-sahil Thanks for your contribution! Do you know if there are still scenarios where this attribute won’t be found? (Considering if we need to add default values for the padding)