[Android] Date order is wrong according to the locale's preference

UnableHead commented 5 years ago

Hello,

I have a problem about the date order on Android. I try on iOS it works fine.

It set the locale props at fr-FR, the month name translation is correct, and the order date is MM-DD-YYYY but the correct French order should be DD-MM-YYYY.

I search in code and I found this in the file ./node_modules/react-native-date-picker/android/src/main/java/com/henninghall/date_picker/WheelOrderUpdater.java at the line 27 :

private ArrayList<Wheel> localeToWheelOrder(final Locale locale) {
        final ArrayList<Wheel> wheelList = new ArrayList<Wheel>();
        if (Utils.monthNameBeforeMonthDate(locale)) {
            wheelList.add(this.pickerView.dateWheel);
            wheelList.add(this.pickerView.monthWheel);
        }
        else {
            wheelList.add(this.pickerView.monthWheel);
            wheelList.add(this.pickerView.dateWheel);
        }
        return wheelList;
    }

I guess as the function name means monthNameBeforeMonthDate that we should swap the lines in the if like this :

private ArrayList<Wheel> localeToWheelOrder(final Locale locale) {
        final ArrayList<Wheel> wheelList = new ArrayList<Wheel>();
        if (Utils.monthNameBeforeMonthDate(locale)) {
            wheelList.add(this.pickerView.monthWheel);
            wheelList.add(this.pickerView.dateWheel);
        }
        else {
            wheelList.add(this.pickerView.dateWheel);
            wheelList.add(this.pickerView.monthWheel);
        }
        return wheelList;
    }

I hope this will help to fix the problem. If needed, I could do a pull request (never done this before).