Validator errors in my forked version

[martindusinberre]

@henokemp A final thing: I ran the validator in my forked version just now. Hopefully @interrogator has already set you up with the validator and you may have picked these errors up already, but if not:

• in 1.4.2 imageComponent2 you have a string to resources/ds1.jpg but the actual file in the Resources folder has a PNG extension. Change the extension in the Resources folder and the error should go, meaning the importer doesn't crash at this point (NB: if you were reading the importer, as explained in #9 , you would see that the last line of the import was something like 1.4.2/imageComponent2.json, meaning that this was where the importer had tripped up. This would be enough information for you to go back and double check all the json content imputs you've made and correct and push again.)
• Similar problem to above: in 1.4.2 imageComponent3 you have the string resources/ds1_picture.jpg but the actual file extension in the Resources folder is .png. Please change this extension to .jpg and the problem should disappear.

OK, that's it from me for the time being! Sorry to be slow in doing all this, but hope it gives you some stuff to think about in advance of our next stand-up meeting on Tuesday. All best, Martin

[henokemp]

@interrogator Already informed me about the png vs jpg errors and I've fixed them.

No worries about the speed. I'll make the changes as described in the other issues and mainly think about dialog. As I already mentioned, I was able to play up until 1.5.1 sometime past week. This means I was already able to fix some issues. I'm looking forward to the next import to the text-system. :)

[henokemp]

Regarding the validator: @interrogator did not personally set me up, rather I just downloaded it myself. I am able to use it, but the output is a little confusing, to be honest, and might be the reason why the system is crashing as soon as I push new changes.

When I run maruval lit-feelingthepast the out put looks like this:

Validating content at /home/henrik/lit-feelingthepast
107 JSON files found.

====================================================================================================
Problem #1 -- Content error in /home/henrik/lit-feelingthepast/chapter1/1.0.0/imageComponent1.json
----------------------------------------------------------------------------------------------------

/home/henrik/lit-feelingthepast/chapter1/1.0.0/imageComponent1.json has key 'images', but resources/1.0.0_garden.jpg not found.

====================================================================================================
Problem #2 -- Content error in /home/henrik/lit-feelingthepast/chapter1/1.0.0/pageTransition1.json
----------------------------------------------------------------------------------------------------

/home/henrik/lit-feelingthepast/chapter1/1.0.0/pageTransition1.json has key 'to', but chapter1/1.0.1/page.json not found.

====================================================================================================
Problem #3 -- Content error in /home/henrik/lit-feelingthepast/chapter1/1.0.0/pageTransition2.json
----------------------------------------------------------------------------------------------------

/home/henrik/lit-feelingthepast/chapter1/1.0.0/pageTransition2.json has key 'to', but chapter1/1.0.1/page.json not found.

====================================================================================================
Problem #4 -- Content error in /home/henrik/lit-feelingthepast/chapter1/1.0.1/character1.json
----------------------------------------------------------------------------------------------------

/home/henrik/lit-feelingthepast/chapter1/1.0.1/character1.json has key 'image', but resources/character1.jpg not found.

====================================================================================================
Problem #5 -- Content error in /home/henrik/lit-feelingthepast/chapter1/1.0.1/imageComponent1.json
----------------------------------------------------------------------------------------------------

/home/henrik/lit-feelingthepast/chapter1/1.0.1/imageComponent1.json has key 'images', but resources/1.0.0_garden.jpg not found.

====================================================================================================
Problem #6 -- Content error in /home/henrik/lit-feelingthepast/chapter1/1.0.1/mail1.json
----------------------------------------------------------------------------------------------------

/home/henrik/lit-feelingthepast/chapter1/1.0.1/mail1.json has key 'from', but chapter1/1.0.1/character1.json not found.

In total 67 content errors looking similar to this, I assume for every pageTransition and image one. I'm a little lost how I can fix this, maybe @interrogator can help.

[interrogator]

be sure to cd into the the root of lit-feelingthepast and run maruval ., rather than being outside the game directory and doing maruval lit-feelingthepast. Currently i get no errors for master branch doing it that way.

and be sure you have the most up-to-date validator running:

pip uninstall marugoto-validator
pip install git+https://github.com/uzh/marugoto-validator

This is the most recent version of the validator, pip install marugoto-validator may be a bit out of date, my bad.

[interrogator]

@henokemp I just put your game back online on the test system. Not sure why it was down, nature of the beast unfortunately.

[interrogator]

@martindusinberre those errors are fixed now, and may have been at the time you ran the validation. Going forward, make sure you stay on master branch, git pull and have the latest content before validating this game. (obviously, different workflow from PL where you are the sole contributor)