search

henokkhm / microverse-module-4-ruby-group-capstone

This is the group capstone project for Module 4 - Week 5 of the Full-Stack Developer program offered by Microverse.
MIT License
1 stars 1 forks source link

Kanban Board Review #21

Open henokkhm opened 1 year ago

henokkhm commented 1 year ago

Link to your GitHub project: https://github.com/henokkhm/microverse-module-4-ruby-group-capstone/projects/1

There are three people in our team.

Olamarx commented 1 year ago

Hi Team,

Good job so far, indeed you have spent time on this project! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Required Changes ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

joel-kalema commented 1 year ago

Hi Team

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

Congratulations! 🎉

Highlights

Good use of Kanban board 👍

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @joel-kalema in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.