henon / Python.Included

A Python.NET based framework enabling .NET libraries to call into Python packages without depending on a local Python installation.
MIT License
321 stars 52 forks source link

Use quotation marks to support all possible install paths #33

Closed rvetere closed 2 years ago

rvetere commented 2 years ago

I have tried to address following issue: fixes #31

This should allow paths with spaces in them - but i have not tested it yet.

henon commented 2 years ago

Ok, please test before I merge it.

henon commented 2 years ago

@rvetere did you test it?

JimiC commented 2 years ago

@henon In order for curl output to resolve paths with spaces in it, the path needs to be inside quotes (either double or single).

Screenshot of testing.

  1. Failure when no quotation used
  2. Using single quote
  3. Using double quotes

image

henon commented 2 years ago

Thanks for the PR @rvetere and thanks for testing and bringing this back to my attention @JimiC

Released as https://www.nuget.org/packages/Python.Deployment/1.4.1 https://www.nuget.org/packages/Python.Included/3.10.0-preview4