search

henrichg / PhoneProfilesPlus

Profile manager for Android - event triggered
Apache License 2.0
423 stars 32 forks source link

Notification in dark mode #90

Closed RuboGubo closed 2 years ago

RuboGubo commented 2 years ago

When in dark mode, the background of the notificarion does not go dark, which is anoying. (Not a big deal though) Screenshot_20220827-223131_Firefox

henrichg commented 2 years ago

Uff, not good. How is configured PPP Settings/"Application notification"/"Background color"? "Native"? And in device is set Dark mode? Write me also, Androide version, device name. Thanks.

RuboGubo commented 2 years ago

Hi, the "background colour" is set to native, and the device is set to native via the system setting. In regards to the other information; I am on android version 9 and am using a Samsung Galaxy S8.

On Sat, Aug 27 2022 at 14:37:31 -0700, Henrich Gron @.***> wrote:

Uff, not good. How is configured PPP Settings/"Application notification"/"Background color"? "Native"? And in device is set Dark mode? Write me also, Androide version, device name. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/henrichg/PhoneProfilesPlus/issues/90#issuecomment-1229272514, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARSOFBPAWRKTAAOWHO2BMDDV3KDBXANCNFSM57Z6C4MQ. You are receiving this because you authored the thread.Message ID: @.***>

henrichg commented 2 years ago

...the device is set to native via the system setting...

Native? What is "native"? In your device is not Dark mode? Maybe it is named as "Device theme"? Hm, PPP uses transparent background color for "Background color"="Native", but this is white color. Not good. Then change "Background color" to "Dark" or "Black" or "Custom color" and set "Custom background color". Or you can set "Notification style" to "Native".

This must be "bug" in Android 9. In source code of PPP I have comment:

// In 28 (Android 9) exists Dark theme, but not working in emulator,
// must be tested in device (for example Nexus 5x).

Dark theme not working also in your device :-(

RuboGubo commented 2 years ago

Sorry, i meant dark mode. Also, i have just discovered that the generated notification when set in a profile does have the correct background colour.

On Sat, Aug 27 2022 at 16:02:27 -0700, Henrich Gron @.***> wrote:

...the device is set to native via the system setting...

Native? What is "native"? In your device is not Dark mode? Maybe it is named as "Device theme"? Hm, PPP uses transparent background color for "Background color"="Native", but this is white color. Not good. Then change "Background color" to "Dark" or "Black" or "Custom color" and set "Custom background color". Or you can set "Notification style" to "Native".

This must be "bug" in Android 9. In source code of PPP I have comment:

// In 28 (Android 9) exists Dark theme, but not working in emulator, // must be tested in device (for example Nexus 5x). Dark theme not working also in your device :-(

— Reply to this email directly, view it on GitHub https://github.com/henrichg/PhoneProfilesPlus/issues/90#issuecomment-1229290313, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARSOFBNBN3X2S36SGK7DIRDV3KNAHANCNFSM57Z6C4MQ. You are receiving this because you authored the thread.Message ID: @.***>

henrichg commented 2 years ago

Then all is OK? Notification background is dark?

RuboGubo commented 2 years ago

Yes, this should all work, not ideal for new users though.

On Sat, Aug 27 2022 at 16:24:24 -0700, Henrich Gron @.***> wrote:

Then all is OK? Notification background is dark?

— Reply to this email directly, view it on GitHub https://github.com/henrichg/PhoneProfilesPlus/issues/90#issuecomment-1229316897, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARSOFBIUJP3MDTL3HMW55QTV3KPSRANCNFSM57Z6C4MQ. You are receiving this because you authored the thread.Message ID: @.***>

henrichg commented 2 years ago

Yes, I will looing on it. Which PPP version you have installed? Latest is 6.0.1.

RuboGubo commented 2 years ago

Yes i am currently on 6.0.1

On Sat, Aug 27 2022 at 16:27:30 -0700, Henrich Gron @.***> wrote:

Yes, I will looing on it. Which PPP version you have installed? Latest is 6.0.1.

— Reply to this email directly, view it on GitHub https://github.com/henrichg/PhoneProfilesPlus/issues/90#issuecomment-1229320762, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARSOFBOXHFKFEXRV7TBD6RDV3KP6FANCNFSM57Z6C4MQ. You are receiving this because you authored the thread.Message ID: @.***>

henrichg commented 2 years ago

I'm tested it in Nexus 5x with Android 9 and working good. Background was changed by Dark theme. Maybe bug is in Samsung Android. Not good.

RuboGubo commented 2 years ago

For some reason the normal notifications gen from profiles work fine. Screenshot_20220828-113948_Firefox

henrichg commented 2 years ago

Up is "Activated profile" notification. It is main notification of PPP. In PPP Settings "Application notification" are settings for it. If in these settings, "Notification style"="Native", used is system notification and background color is set by system. If "Notification style"="Custom", used is custom layout from PPP and for it must be configured correct "Background color".

Next is, by me, notification generated by profile activation, parameter "Others"/"Generate notification". It uses system notification, background color is set by system.