Ordos campaign missions result in zero scores

[juj]

Got this result after completing the second level of Ordos campaign by destroying the Harkonnen base:

I did not harvest the 2700 spice that was needed, but won by destroying the base. Had three harvesters during the mission, so harvested maybe 6-10 full harvester runs. Both sides definitely lost units, though I did not lose any buildings.

Not sure if this scoring mismatch generally happens on other/all missions - though definitely in that one.

[juj]

It does seem to occur systematically. Level 3 victory results looked the same:

[henricj]

Those zeros look very suspicious. I'm not sure why the game would end early, but the zero score is probably something I've broken recently in in CampaignStatsMenu.cpp.

[juj]

Completed the Ordos campaign, and looks like all missions did result in a zero score.

[juj]

The same issue is not occurring on Atreides campaign, but there the score screen does give out proper scores:

[henricj]

Did you play the Ordos campaign with or without the (alleged) fix? https://github.com/henricj/dunelegacy/commit/e38505b680513143abff8f92cfeba528f0cec223

[juj]

I think I played it without, Ordos build was from yesterday.

[juj]

Looks like this works now! Ordos campaign mission 1:

Mission 2:

[juj]

The second Ordos mission still finished without needing to harvest the 2700 spice by destroying the Harkonnen base. Not sure if that is intentional or not:

Although I do kind of like that it is that way - kind of anticlimactic to have to farm 2700 right after having destroyed the enemy base. Although iirc Atreides level 2 is identical: "harvest 2700 and there's enemy base" - and there one does have to harvest up to 2700 even after destroying the base.

[henricj]

"Just hit F6 a couple of times." More seriously, that is probably worth looking into. If it says to harvest 2700, one should probably have to harvest 2700 before winning. We should probably open another issue to track this win condition problem.

[juj]

We should probably open another issue to track this win condition problem.

Check, marked this down as #27.