add elixir 1.7 support - Githubissues

henrik / progress_bar

Command-line progress bars and spinners for Elixir.

MIT License

329 stars 20 forks source link

add elixir 1.7 support #21

Closed ayrat555 closed 5 years ago

ayrat555 commented 5 years ago

Changes:

fix compilation warnings for Elixir 1.7
fix Stream.cycle for empty enum (elixir 1.5 change - https://github.com/elixir-lang/elixir/blob/v1.5/CHANGELOG.md#elixir-6)

ayrat555 commented 5 years ago

@henrik can you please review this PR?

henrik commented 5 years ago

Hi @ayrat555! Thanks so much for the PR. Hope to get around to it within the next few days.

ayrat555 commented 5 years ago

@henrik ping

henrik commented 5 years ago

Sorry about that, merging it now! Life gets busy.

Are all the formatting changes required to avoid warnings? Or are they the result of the Elixir code formatter? Some of them run counter to my preferences (I see reasons to keep trailing commas on the last line of an array, and moving an end-of-line comment above it without extra blank lines blurs the comment scope) but I'll take them if that's what Elixir demands :D

henrik commented 5 years ago

Released the package as 1.7.0.

ayrat555 commented 5 years ago

thanks