search

henrikingo / impressionist

A Visual 3D editor for creating stunning impress.js presentations
MIT License
197 stars 37 forks source link

fixed include file for electron #10

Closed tojocky closed 6 years ago

davegregg commented 6 years ago

Your variable impresionistResourcesPath misspells "impressionist", creating an inconsistency which could lead to typos unless corrected.

henrikingo commented 6 years ago

Closing, as #9 was merged instead. Thanks for helping out though, and especially thanks to @davegregg for helping with reviewing!

henrikingo commented 6 years ago

I decided to use this after all, since __dirname will work regardless of how and where electron was started. #9 assumed user is always in the repository root.

I committed and pushed locally to fix the typo. I thought git apply was preserving the author, as it was in the patch, but it didn't. Sorry about that @tojocky. Thanks for the help in any case.