henrikingo / impressionist

A Visual 3D editor for creating stunning impress.js presentations
MIT License
198 stars 37 forks source link

Keyboard not working when adding link, cannot change step id & mobile issue #41

Open Yyatiko opened 3 years ago

Yyatiko commented 3 years ago

Hi,

thanks for this very nice project. I'll be using it a lot I think. Here is my first try : www.fractal11.c1.biz

I'm running impressionist on mac book Air, OS Mojave 10.14.6

1) When I want to add a link in a slide/step, the window "insert link" shows up, but when I try to type, it opens shortcuts. Like pressing on "p" opens the "impressConsole" even though I can see my cursor blinking in the URL field to type text in the window. I cannot copy and past as well in the insert link window using cmd+C/V, But I can copy and past using the UI toolbar.

2) I cannot change the id of a step using the "outline" menu on top, but I can reorder step.

3) the presentation transitions on www.fractal11.c1.biz doesn't work well on my iphone. It transitions when you swipe on the screen, but make very strange zooms and it is quite hard to transition between steps. I've tryed other website using impress.js and it gives the same issue, only some work like the one from gossip (I cannot find it anymore)

I do have npm issues still and if I use nom audit fix --force the electron app doesn't open files anymore and it is not working. So my current installation has the following issues, but still allow me to use the app quite well :

# npm audit report

clean-css  <4.1.11
Regular Expression Denial of Service - https://npmjs.com/advisories/785
fix available via `npm audit fix --force`
Will install buildify@0.2.0, which is a breaking change
node_modules/clean-css
  buildify  *
  Depends on vulnerable versions of clean-css
  Depends on vulnerable versions of uglify-js
  node_modules/buildify

electron  <=9.3.5 || 10.0.0 - 10.1.7 || 11.0.0 - 11.0.5
Severity: critical
IPC messages delivered to the wrong frame - https://npmjs.com/advisories/1615
Chromium Remote Code Execution - https://npmjs.com/advisories/539
Remote Code Execution - https://npmjs.com/advisories/563
Code Execution by Re-enabling Node.js integration - https://npmjs.com/advisories/574
fix available via `npm audit fix --force`
Will install electron@1.8.8, which is outside the stated dependency range
node_modules/electron

tinymce  <=5.7.0
Severity: moderate
Cross-site scripting in TinyMCE - https://npmjs.com/advisories/1601
Cross-site scripting in TinyMCE - https://npmjs.com/advisories/1680
Cross-Site Scripting - https://npmjs.com/advisories/1749
fix available via `npm audit fix --force`
Will install tinymce@4.9.11, which is outside the stated dependency range
node_modules/tinymce

trim-newlines  <3.0.1 || =4.0.0
Severity: high
Regular Expression Denial of Service - https://npmjs.com/advisories/1753
fix available via `npm audit fix`
node_modules/trim-newlines
  meow  3.4.0 - 5.0.0
  Depends on vulnerable versions of trim-newlines
  node_modules/meow

uglify-js  <=2.5.0
Incorrect Handling of Non-Boolean Comparisons During Minification - https://npmjs.com/advisories/39
Regular Expression Denial of Service - https://npmjs.com/advisories/48
fix available via `npm audit fix --force`
Will install buildify@0.2.0, which is a breaking change
node_modules/uglify-js
  buildify  *
  Depends on vulnerable versions of clean-css
  Depends on vulnerable versions of uglify-js
  node_modules/buildify

underscore  1.3.2 - 1.12.0
Severity: high
Arbitrary Code Execution - https://npmjs.com/advisories/1674
fix available via `npm audit fix`
node_modules/underscore

8 vulnerabilities (3 low, 1 moderate, 3 high, 1 critical)

Thanks for your help and be well.