search

henrikingo / impressionist

A Visual 3D editor for creating stunning impress.js presentations
MIT License
197 stars 37 forks source link

Use process.cwd() as base of js/css paths #9

Closed ecuk closed 6 years ago

ecuk commented 7 years ago

Using process.resourcesPath as the base of js/css paths does not work on macOS/darwin because the macOS app bundle means that process.resourcesPath is two levels lower than it (apparently) is on Linux. I do not know where the resourcesPath falls in a Windows build, but using process.cwd() should make it work cross-platform.

Note that process.cwd() returns the base of the impressionist folder hierarchy, in my case /Users/eric/Developer/impressionist. This eliminates the many levels of '/../../../..' needed when using process.resourcesPath. I assume other platforms return the same cwd but am not able to test this.

henrikingo commented 6 years ago

Thanks. Sorry I have forgotten about this. I was focused on impress.js itself last year and only now stumbled back on this and remembered to merge.

Thanks for helping out! I can certainly use help both wrt Mac and Electron itself.