search

henriklovhaug / md-tui

Markdown renderer in the terminal
GNU Affero General Public License v3.0
208 stars 13 forks source link

Link find should try where the user is first #1

Closed henriklovhaug closed 7 months ago

henriklovhaug commented 8 months ago

I'm not sure how it should behave when you are at the top of the file versus one line down. Should go to the one at the top or the middle of the screen?

Areskiko commented 8 months ago

Jump to first occurrence in the user's view

Fildor commented 7 months ago

Just to recap how I understand the question:

We have something like ...

[Some Link Number 1](http://domain.com/resouce.html)

["Position" or Cursor is here]: #

[Some Link Number 2](someOtherTarget)

And question is: should Link1 or Link2 be selected first? Is that correct?

Assuming correct, I (personal opinion) would probably expect Link 2 to be selected first and then "modulo" back to the first in view for subsequent calls.

Except if there were two different Key-Maps for "Find" and "Find next". If only one Key-Map, then I would expect the described behavior.

But: I really do not think it matters that much. Just pick the one that's reasonable to you (again: imho).

Regards, Fil

henriklovhaug commented 7 months ago

As cursor is not a concept in this TUI yet (todo?), the only reference points for a user is where on the screen or in the document the link selection should start from. So currently I see two possible options: top of the screen, and middle of the screen.