henrikruscon / hyper-statusline

Status Line Plugin for Hyper
MIT License
390 stars 79 forks source link

Plugins #1

Closed ada-lovecraft closed 7 years ago

ada-lovecraft commented 7 years ago

I really like this plugin compared to the alternative. It's clean and simple and I feel like it has a lot of room for a plugin architecture so that devs could add something like:

Thoughts?

henrikruscon commented 7 years ago

@codevinsky Thanks! πŸ‘Š

I agree, there's definitely room for additions. So far I've only added what I personally use.

Sadly there's currently no way that I'm aware of to have a plugin depend on another plugin in Hyper.

I'd need more details on features you'd like to see if you want me to code them in or you could PR them yourself. ✌️

henrikruscon commented 7 years ago

@codevinsky, @s2tephen

Made a version that checks if repo is dirty. What do you think about it? Worth including?

dirty

s2tephen commented 7 years ago

Looks good to me! What states are you including and what icons will you use to represent them?

henrikruscon commented 7 years ago

@s2tephen Neat! ✌️

Currently only shows if the repo is dirty or not. Thinking of adding unpulled/unpushed with down/up arrow icons as well.

henrikruscon commented 7 years ago

Feedback would be neat on push/pull status. Would it be better to stick with boxed icons?

push

caesar commented 7 years ago

@henrikdahl I think https://github.com/zeit/hyper/pull/1261 would enable this type of extensibility, no?

caesar commented 7 years ago

BTW I like the push/pull status idea, but it took me a while to work out what the square with the dot in it means… maybe the icons could have tooltips when you hover the mouse over them?

henrikruscon commented 7 years ago

@caesar Great find. I'll definitely update my code once it's in release, which could be a while ✌️

GitHub actually uses the same icon to represent diff, but even so it's not very self explanatory unless you've previously seen it.

I'll add native tooltips for now. I've actually been wanting to add my own custom tooltips but I've simply lacked time.

timneutkens commented 7 years ago

@henrikdahl @caesar Landed this in Hyperline dev branch: https://github.com/NickTikhonov/hyperline/tree/develop. Really like the design of this status line + features, maybe we can combine forces? πŸ‘ πŸŽ‰ Be sure to check https://zeit.chat πŸ˜„

henrikruscon commented 7 years ago

Just committed a version that now supports pull/push ✌️