search

henrikruscon / hyper-statusline

Status Line Plugin for Hyper
MIT License
387 stars 79 forks source link

Icon for 'git dirty' isn't visible in macOS #25

Closed enriquecaballero closed 7 years ago

enriquecaballero commented 7 years ago
screen shot 2017-01-10 at 2 35 19 pm

Also, none of the git stuff seems to work for me in Ubuntu

henrikruscon commented 7 years ago

Could you try enforce an update of hyper-statusline by commenting it out, restarting hyper and then comment it back in and restart hyper. Does that fix the git dirty visibility? ✌️

enriquecaballero commented 7 years ago

Nope, still nothing :-S

henrikruscon commented 7 years ago

Anything in console? Can you inspect the element with dev tools to see what icon it's referencing to?

enriquecaballero commented 7 years ago

Found it.

screen shot 2017-01-10 at 11 31 59 pm

Problem seems to be with the background-color property. Once I set it to 'grey', the dirty icon was visible.

henrikruscon commented 7 years ago

Did you by any chance remove your colors in your hyper.js config? Seems it's having issues fetching the config color yellow.

enriquecaballero commented 7 years ago

Here's what my ~/.hyper.js config looks like

module.exports = {
  config: {
    fontSize: 13,
    fontFamily: 'Andale Mono, monospace',
    cursorColor: 'rgba(248,28,229,0.8)',
    cursorShape: 'BLOCK',
    foregroundColor: '#fff',
    backgroundColor: '#000',
    borderColor: '#333',
    css: '',
    termCSS: `
      x-screen a {
        color: #F92672;
      }
    `,
    showHamburgerMenu: '',
    showWindowControls: '',
    padding: '12px 14px',
    colors: {
      black: '#000000',
      red: '#ff0000',
      green: '#33ff00',
      yellow: '#ffff00',
      blue: '#0066ff',
      magenta: '#cc00ff',
      cyan: '#00ffff',
      white: '#d0d0d0',
      lightBlack: '#808080',
      lightRed: '#ff0000',
      lightGreen: '#33ff00',
      lightYellow: '#ffff00',
      lightBlue: '#0066ff',
      lightMagenta: '#cc00ff',
      lightCyan: '#00ffff',
      lightWhite: '#ffffff'
    },
    shell: '',
    shellArgs: ['--login'],
    env: {},
    bell: false,
    copyOnSelect: true
  },
  plugins: [
    "hyperterm-monokai",
    "hyper-statusline",
    "hyperlinks",
    "hyperterm-themed-scrollbar",
    "hyper-blink",
    "hyperterm-cursor"
  ],
  localPlugins: []
};
henrikruscon commented 7 years ago

Did you try just running hyper-statusline to see if it's related to another plugin?

enriquecaballero commented 7 years ago

That did it. It doesn't seem to play well with hyperterm-monokai.

henrikruscon commented 7 years ago

Just checked hyperterm-monokai method for applying the colors to the config appears to break my fetching.

I suggest you let the author know or switch theme ✌️