search

henrikruscon / hyper-statusline

Status Line Plugin for Hyper
MIT License
387 stars 79 forks source link

loss of functionality after switch to zsh #30

Closed nhejazi closed 7 years ago

nhejazi commented 7 years ago

I've been using this plugin with Hyper (v1.1.0 currently), recently after a switch to zsh on macOS, the functionality seems to go dead. That is, I've set Hyper to use bash as the default shell, and the plugin works fine; when I switch over to zsh, the plugin stops working. Is zsh not supported? I'm having trouble identifying the source of this error.

henrikruscon commented 7 years ago

It supports zsh, I use zsh myself. Could you give a little more information about your entire environment? ✌️

nhejazi commented 7 years ago

Ok, good to know. So definitely something on my end then. Basically, I fire up Hyper (v1.1.0) and the plugin works fine when I am in a git repo. If I switch over to zsh, by simply typing zsh, all aspects of the plugin stop working (it doesn't track directory or whether the directory is a git repo at all). I'm happy to provide more information, just not sure what exactly might be relevant. Thanks in advance.

Here's excerpts of my hyper.js (only secion that I thought relevant):

// the shell to run when spawning a new session (i.e. /usr/local/bin/fish)
    // if left empty, your system's login shell will be used by default
    shell: 'bash',

    // for setting shell arguments (i.e. using interactive shellArgs: ['-i'])
    // by default ['--login'] will be used
    shellArgs: ['--login'],

    // for environment variables
    env: {},

    plugins: [
      "hypercwd",
      "hyperlinks",
      "hyper-blink",
      "hyperterm-tabs",
      "hyperterm-paste",
      "hyperterm-cursor",
      "hyper-statusline",
      "hyperterm-bold-tab",
      "hyper-snazzy" // Snazzy theme
    ],
henrikruscon commented 7 years ago

Does it work if you actually start with zsh instead of switching in shell?

You should ideally run hyper-snazzy before hyper-statusline so that it can match it's colors, if you run it after it will match Hyper default instead.

nhejazi commented 7 years ago

Setting shell: zsh fixed the problem. Is there some way to start a zsh session and still have the plugin work? I'm not sure what the cause of this error is.

And thanks for the tip re: hyper-snazzy and hyper-statusline; I've adjusted my hyper.js accordingly

henrikruscon commented 7 years ago

@nhejazi after some testing I've concluded that this is surely related to hterm or Hyper itself so I'm closing this for now ✌️