henrikruscon / hyper-statusline

Status Line Plugin for Hyper
MIT License
387 stars 79 forks source link

dirty and arrows indicators not showing #33

Closed brandonweiss closed 7 years ago

brandonweiss commented 7 years ago
screen shot 2017-02-12 at 8 43 25 pm

I'm on the latest version of Hyper and I disabled other plugins, so I don't think it's another one interfering. There's nothing in the console.

screen shot 2017-02-12 at 8 47 20 pm

It looks like the problem is the background-color for the icons is being set to undefined… I'm not overriding them so for some reason the default/fallback at config.colors.lightYellow and config.colors.blue must be undefined.

brandonweiss commented 7 years ago

Oh, apparently I have this in my config:

colors: [
  '#000000',
  '#ff0000',
  '#33ff00',
  '#ffff00',
  '#0066ff',
  '#cc00ff',
  '#00ffff',
  '#d0d0d0',
  '#808080',
  '#ff0000',
  '#33ff00',
  '#ffff00',
  '#0066ff',
  '#cc00ff',
  '#00ffff',
  '#ffffff'
]

If colors is supposed to be an object instead of an array then that seems like that's the problem. Although if I comment it out it seems to stop hyper from loading. So weird… I have no idea where this came from…

brandonweiss commented 7 years ago

Ah, I generated a new, default config file and it has this in it:

colors: {
  black: '#000000',
  red: '#ff0000',
  green: '#33ff00',
  yellow: '#ffff00',
  blue: '#0066ff',
  magenta: '#cc00ff',
  cyan: '#00ffff',
  white: '#d0d0d0',
  lightBlack: '#808080',
  lightRed: '#ff0000',
  lightGreen: '#33ff00',
  lightYellow: '#ffff00',
  lightBlue: '#0066ff',
  lightMagenta: '#cc00ff',
  lightCyan: '#00ffff',
  lightWhite: '#ffffff'
}

I guess the format must have changed but they didn't migrate the setting. Updating the colors config to that fixed the problem.

I'm going to close this, but feel free to reopen if you want to handle this case! 😄