Icons path broken on Windows

henrikruscon / hyper-statusline

Status Line Plugin for Hyper

MIT License

387 stars 79 forks source link

Icons path broken on Windows #6

Closed Naramsim closed 7 years ago

Naramsim commented 7 years ago

Hi, I am using Hyper v1.0.0 on my Win 10 The console shows this error: screenshot 229

The path isn't correct it should be: file:///C:/Users/Ale/.hyper_plugins/node_modules/hyper-statusline/icons/dirty.svg

henrikruscon commented 7 years ago

@Naramsim Mind trying if the icon path is fixed on the os-windows branch? I can't debug myself without Windows ✌️

s2tephen commented 7 years ago

Not sure if @henrikdahl merged this fix with master, but now icons aren't showing up for me on Mac OSX.

The CSS property is -webkit-mask-image: url(./icons/folder.svg); but for me that path points to file:///Applications/Hyper.app/Contents/Resources/app/icons/folder.svg, rather than looking in the .hyper_plugins/node_modules folder.

henrikruscon commented 7 years ago

@s2tephen Sorry about that. Was unintentional, tired mistake and tight schedule 😅

If you force an update it's been reverted.