henrikruscon / hyper-statusline

Status Line Plugin for Hyper
MIT License
386 stars 79 forks source link

Hyper@1.4 breaks styles #61

Open brandonweiss opened 6 years ago

brandonweiss commented 6 years ago

I'm pretty sure some CSS selectors must have changed or something… I updated to the latest version of Hyper and the status line looks like this now.

screen shot 2017-09-05 at 11 23 25 am
kajka commented 6 years ago

@brandonweiss I solved this problem.

  1. I relocated plug-in from directory node_modules to local.
  2. I modified the configuration in the .hyper.js file accordingly.
  3. I installed missing modules (tildify after-all-results) for hyper-statusline to node_modules directory (via yarn/npm).

Looks like it's working right now again properly.

screen shot 2017-09-26 at 17 44 11

brandonweiss commented 6 years ago

@kajka By “solved” you mean you figured out how to temporarily make it work for you locally, yes? Do you know what the actual problem/solution is? Like is it just some undeclared dependencies?

kajka commented 6 years ago

No I don't now what actual problem is. Unfortunately, the solution is not permament :(.

henrikruscon commented 6 years ago

Are you sure hyper-statusline is listed after your theme in plugins? ✌️

kajka commented 6 years ago

Unfortunately no. I use my own theme, which is located in localPlugins. Indeed, this can be an issue; when I add different theme under plugins section, hyper-statusline plugins works fine!

henrikruscon commented 6 years ago

There's really not much that can be done here by hyper-statusline since that's how Hyper handles plugins. hyper-statusline cannot fetch theme colors unless the theme has already been loaded.

What you could do is run hyper-statusline locally as well but that's not ideal I guess ✌️

brandonweiss commented 6 years ago

@henrikdahl Jaysus, that was the problem? I had no idea themes needed to be loaded before plugins… that's so brittle. How are people not constantly running into this problem?

marcinczenko commented 6 years ago

Hmm - this still does not seem to be working for me. I have the following setting:

hyperStatusLine: {
  dirtyColor: 'salmon',
  aheadColor: 'greenyellow'
},

and

plugins: [
  'hyper-chesterish',    
  'hypercwd',
  'hyper-statusline'
],

The dirtyColor and aheadColor does not seem to have any effect. Regardless of the state of my repo, I always get the same view:

hyper

Or I misunderstood the meaning of dirtyColor and aheadColor? Is it that dirtyColor means that the branch name will get this color when the repo has uncommitted changes? And what is then aheadColor?

Thanks in advance for any clarifications.