henrikruscon / hyper-tabs-enhanced

Enhanced Tabs Plugin for Hyper
MIT License
192 stars 20 forks source link

Not getting traffic buttons #17

Closed mattbanks closed 7 years ago

mattbanks commented 7 years ago

Just installed hyperTabs and am seeing an issue with no traffic buttons showing up.

screenshot 2017-05-10 10 24 47

Here's my config:

hyperTabs: {
    trafficButtons: true,
    border: true,
    tabIconsColored: true,
    activityColor: 'salmon'
}

macOS Sierra 10.12.4 Hyper Version 1.3.2 (1.3.2.1744)

Hyper plugins installed:

plugins: [
    'hyper-snazzy',
    'hyperlinks',
    'hyper-tabs-enhanced'
],
lukasmalkmus commented 7 years ago

Can confirm. The option does not seem to work.

simonbusborg commented 7 years ago

Can confirm, still an issue. Same goes for other settings (pulse, Colored icons etc.)

henrikruscon commented 7 years ago

Sorry for delayed response!

I can't reproduce this issue. Is this still an issue with Hyper 1.3.3?

Could you possibly provide your full .hyper.js config? ✌️

lukasmalkmus commented 7 years ago
// Future versions of Hyper may add additional config options,
// which will not automatically be merged into this file.
// See https://hyper.is#cfg for all currently supported options.

module.exports = {
  config: {
    // default font size in pixels for all tabs
    fontSize: 14,

    // font family with optional fallbacks
    fontFamily: 'Hack, Menlo, "DejaVu Sans Mono", Consolas, "Lucida Console", monospace',

    // terminal cursor background color and opacity (hex, rgb, hsl, hsv, hwb or cmyk)
    cursorColor: 'rgba(248,28,229,0.8)',

    // `BEAM` for |, `UNDERLINE` for _, `BLOCK` for █
    cursorShape: 'BLOCK',

    // set to true for blinking cursor
    cursorBlink: true,

    // color of the text
    foregroundColor: '#fff',

    // terminal background color
    backgroundColor: '#000',

    // border color (window, tabs)
    borderColor: '#333',

    // custom css to embed in the main window
    css: '',

    // custom css to embed in the terminal window
    termCSS: '',

    // set to `true` (without backticks) if you're using a Linux setup that doesn't show native menus
    // default: `false` on Linux, `true` on Windows (ignored on macOS)
    showHamburgerMenu: '',

    // set to `false` if you want to hide the minimize, maximize and close buttons
    // additionally, set to `'left'` if you want them on the left, like in Ubuntu
    // default: `true` on windows and Linux (ignored on macOS)
    showWindowControls: '',

    // custom padding (css format, i.e.: `top right bottom left`)
    padding: '12px 14px',

    // the full list. if you're going to provide the full color palette,
    // including the 6 x 6 color cubes and the grayscale map, just provide
    // an array here instead of a color map object
    colors: {
      black: '#000000',
      red: '#ff0000',
      green: '#33ff00',
      yellow: '#ffff00',
      blue: '#0066ff',
      magenta: '#cc00ff',
      cyan: '#00ffff',
      white: '#d0d0d0',
      lightBlack: '#808080',
      lightRed: '#ff0000',
      lightGreen: '#33ff00',
      lightYellow: '#ffff00',
      lightBlue: '#0066ff',
      lightMagenta: '#cc00ff',
      lightCyan: '#00ffff',
      lightWhite: '#ffffff'
    },

    // the shell to run when spawning a new session (i.e. /usr/local/bin/fish)
    // if left empty, your system's login shell will be used by default
    // make sure to use a full path if the binary name doesn't work
    // (e.g `C:\\Windows\\System32\\bash.exe` instead of just `bash.exe`)
    // if you're using powershell, make sure to remove the `--login` below
    shell: '',

    // for setting shell arguments (i.e. for using interactive shellArgs: ['-i'])
    // by default ['--login'] will be used
    shellArgs: ['--login'],

    // for environment variables
    env: {},

    // set to false for no bell
    bell: 'SOUND',

    // if true, selected text will automatically be copied to the clipboard
    copyOnSelect: true,

    // if true, on right click selected text will be copied or pasted if no
    // selection is present (true by default on Windows)
    quickEdit: true

    // URL to custom bell
    // bellSoundURL: 'http://example.com/bell.mp3',

    // for advanced config flags please refer to https://hyper.is/#cfg
  },

  // a list of plugins to fetch and install from npm
  // format: [@org/]project[#version]
  // examples:
  //   `hyperpower`
  //   `@company/project`
  //   `project#1.0.1`
  plugins: [
    "hyper-chesterish",
    "hyperlinks",
    "hyper-tabs-enhanced",
    "hyper-statusline"
  ],

  // in development, you can create a directory under
  // `~/.hyper_plugins/local/` and include it here
  // to load it and avoid it being `npm install`ed
  localPlugins: [],

  hyperTabs: {
    trafficButtons: true,
    tabIconsColored: true,
    activityColor: 'orange',
  }
};
henrikruscon commented 7 years ago

Problem is that the hyperTabs section needs to be inside the config bracket.

Example:

module.exports = {
  config: {
    hyperTabs: {
      trafficButtons: true,
    }
  },

  plugins: [
    'hyper-chesterish',
    'hyper-tabs-enhanced',
    'hyper-statusline',
  ],

  localPlugins: [],
};
lukasmalkmus commented 7 years ago

Oh... I have never seen the full config tbh. I always edited in vi and did not pay attention to that one bracket... I feel a bit retarded now...

henrikruscon commented 7 years ago

Haha, shit happens. Glad it worked out ✌️