search

henrikruscon / hyper-tabs-enhanced

Enhanced Tabs Plugin for Hyper
MIT License
192 stars 20 forks source link

Add support to keep default window controls #4

Closed jcarrillo7 closed 7 years ago

jcarrillo7 commented 7 years ago

It would be nice if this plugin would only affect the tab style / icons and would not replace the window close/minimize/hide buttons (Mac).

henrikruscon commented 7 years ago

I've been planning to implement this as an option but I've lacked time. I'll look at it soon but feel free to PR it if you want it right now ✌️

henrikruscon commented 7 years ago

Just pushed a version that includes custom traffic buttons that can be enabled by config, default is false

How to enable it is written in readme. Let me know if that works for you @jcarrillo7 ✌️

jcarrillo7 commented 7 years ago

@henrikdahl awesome thanks! I did notice a small inconsistency where the traffic buttons are still grayed out when the window is in focus. The behavior is normally to have color when in focus and not just when you hover over them.

henrikruscon commented 7 years ago

@jcarrillo7 yeah that was an artistic choice because I personally think it looks better blended in.

Would you prefer if it had the default behavior you described? ✌️

jcarrillo7 commented 7 years ago

@henrikdahl personally yes so it fits with the rest of macOS. But I understand if you want to keep it how it is.

jcarrillo7 commented 7 years ago

@henrikdahl Also noticed the traffic icons don't show their symbol when hovered over?

http://www.iostipsandtricks.biz/images/20150507/20150507000015-smhlainyjyz.png

henrikruscon commented 7 years ago

@jcarrillo7 also intentional for a cleaner look, traffic buttons also lack borders if you compare them to original for a flat appearence ✌️

I'll consider adding an option to pick between custom and default traffic lights.

jcarrillo7 commented 7 years ago

@henrikdahl ah yeah that option would be great. The current implementation leads to behavior differences Mainly that the "green" button is supposed to full screen the app on OS X and only maximize it when option is held down.

henrikruscon commented 7 years ago

@jcarrillo7 Not sure if you're still using this but I've decided to replace the custom traffic buttons with native ones. The configuration remains the same ✌️

Pushing the commit now