Icons on tab are not appearing

[possebon]

I'm running the Hyper.js 1.1.0.1408 on macOS Sierra. The icons does not appears as process running.

This is my .hyper.js file: https://gist.github.com/anonymous/13c4f0a3c054b5d183d123bd1fb27998

[henrikruscon]

There's currently no process icon for python. What processes are you using? I'll add support for them ✌️

[henrikruscon]

In the screenshot it looks like you're loading hyper-tabs-enhanced before the theme, if you run it after the theme, it'll take the colors from that theme instead of default Hyper theme.

For example:

  plugins: [
    'hyper-chesterish',
    'hyper-tabs-enhanced',
    'hyper-statusline',
  ],

[possebon]

Basically, Python, mySQL, vim.

Awesome plugin, congratulations.

I tested another tab-icon https://github.com/dfrankland/hyper-tab-icons, but yours is more complete.

You could take a look on other plugin (above) to get inspiration of what icons you could add support.

Best regards,

Fernando Possebon

[henrikruscon]

Thanks! 👊

Just added support for Python & MySQL, it already supported Vim. Let me know if it works for you ✌️

[henrikruscon]

@possebon Is this solved?

[possebon]

@henrikdahl I'll test tonight at my macOS. This should work anyway on Linux, right? I tested now, and still does not show on Python

This is a new install of plugin, so I'm sure that is the latest version. On macOS I need to update it, right?

[henrikruscon]

@possebon Only reliable way to get current running process is through the title, since your linux shell doesn't appear to include python in your title, it won't work.

[possebon]

Humm... I'll take a look on how to do it. I installed no the oh-my-zsh but still does not show the process name on title.

Thanks anyway for your attention @henrikdahl

[possebon]

@henrikdahl I gotta working the process name on title

But still not working the icon. Maybe is not considering case insensitive?

[henrikruscon]

@possebon It appears its not showing any icon? Seems the issue is something else now, it should always show the default one. Can you inspect the HTML to see what's there?

[possebon]

@henrikdahl Do you want I check something in particular?

I'm now with macOS, the same situation, and this is the screen with Developer Tools

[henrikruscon]

@possebon Do you get an icon if you run php for example?

[possebon]

Yes, it works.

[henrikruscon]

@possebon That means you're not running the latest version. Comment out hyper-tabs-enhanced and reload plugins, then comment it back in and restart Hyper to make sure it's running the latest.

[possebon]

I did. After uncomment, I had this screen:

Then after quitting Hyper and loading again, it does not appear anymore, but it's same

How can I check that I'm running the latest version? I checked on index.js inside hyper-plugins/hyper-tab-enhanced, and at least inside the code there is python

[henrikruscon]

You're definitely running the old version. It's just iffy sometimes to make sure it updates to the latest. Usually you have to wait for the message that you can restart after forcing an update.

[possebon]

I'll uninstall the version using npm then install it again with npm, just to make sure....

[possebon]

@henrikdahl finally it's working...

I think that it was conflicting with another hyper plugin (hyper-tab-icons). I uninstalled it, then uninstalled the hyper-tabs-enhanced using the npm, just put the hyper-tabs-enhanced on .hyper.js and voilá!

Thanks for your attention.

Best regards,

Fernando Possebon

[henrikruscon]

@possebon Not sure what theme you're using but it looks like it's similar to mine.

If you're using mine then it's worth mentioning that I don't override cursorColor, if you comment out the cursorColor in config you'll get the theme colored one instead ✌️

[possebon]

Don't wanna bother you, the icon color is not working. Do you think is necessary open a different issue?

plugins: [ 'hyper-chesterish', 'hyper-tabs-enhanced', 'hyper-statusline', 'hyper-dark-scrollbar', 'hyper-fileio', ],

hyperTabs: { tabIconsColored: true, border: true, tabIcons: true, },

hyperStatusLine: {
  dirtyColor: 'salmon',
  arrowsColor: 'ivory',
},

[henrikruscon]

Do you mean the tab icons colored?

Is hyperTabs: {} inside the config: {}? It shouldn't be outside of it next to plugins.

Would probably be ideal if you send your whole config so I can see if anything is wrong.

[possebon]

Ok, this is the whole config:

https://gist.github.com/possebon/465c56ada6b89560c05b8ce14cad4cc4

[possebon]

Do you macOS too? In my case vim does not change the icon.

[henrikruscon]

Use this as your config instead, I fixed the formatting for you https://gist.github.com/henrikdahl/1a8e3da772c8c450a1d9c809c4ceff47

[possebon]

@henrikdahl you're the man! Colors working!

So I checked the differences, the settings are defined before loading the plugins, correct? This is the only change you did?

[henrikruscon]

Is the title vim .hyper.js or vim.hyper.js?

The settings are defined within the config brackets instead of outside.

[possebon]

I change to another file,

[henrikruscon]

If you just type vim without specifying a file, does it show the icon then? Might be an issue with my RegEx.

[possebon]

Yes, without specifying a file, works.

[henrikruscon]

I'll have to update my regex then, mind sharing your title string with me when you specify a file so that I can test against it?

[possebon]

Sure, no problem. I just did vim test.txt on console, on my ~ folder. Is that what you need?

[henrikruscon]

Is the title like this vim test.txt? With a space between?

[possebon]

Yes, that's it. vim space test.txt

[henrikruscon]

@possebon I just published a new version with improved regex matching that should fix your issue ✌️

[possebon]

@henrikdahl Great!