search

henrikx / metroskininstaller

https://metroforsteam.com
GNU Affero General Public License v3.0
199 stars 12 forks source link

Check for manifest file errors #18

Open redsigma opened 6 years ago

redsigma commented 6 years ago

The installer doesn't check against missing extras.

PhantomGamers commented 6 years ago

I'm working on this RN, have the functionality down, needs more testing but I came across another bug while working on this.

Currently we only add entries that have their 3rd group empty if (Regex.Match((manifest[i].Replace("\\", "")), "\"(.*?)\";\"(.*?)\";\"(.*?)\";\"(.*?)\"").Groups[3].Value == "")

What's the purpose of this? Currently the last 3 items in the manifest have text in the third entry so they flat out don't show up on the installer at all, spent hours thinking there was a false negative in my code only to realize that haha

EDIT: Also Henrikx do you have discord? Or is this the best way to contact you?

@henrikx

henrikx commented 6 years ago

See #4 @PhantomGamers

henrikx commented 6 years ago

Adding more to it, some extras are made with two extras combined, because they modify the same file. That field in manifest file says something about which extras it links with

henrikx commented 6 years ago

Btw I am in the Unofficial patch Discord under the name @ciken#9165. I prefer that we communicate about bugs and other development here unless something requires immediate action.