Closed PhantomGamers closed 1 year ago
Hi, this looks great, thanks for doing this!
Do you think we could remove all external dependencies by using the System.IO.Compression methods for ZipFile extraction? https://learn.microsoft.com/en-us/dotnet/api/system.io.compression.zipfile.extracttodirectory?view=net-6.0
It would be possible but it is a similar issue to switching to HttpClient in that .net's ZipFile does not provide an easy way to monitor progress like ionic's does.
I just removed the dependency on System.Text.Encoding.CodePages as it seems it is not needed.
Earlier I was getting a ''IBM437" is not a supported encoding name
error, and I thought adding that solved it but I guess it was something else I changed that wound up solving it.
Now the single exe is smaller than 1.4.16 (424KB vs 1.4.16's 530KB).
(Though you should check to make sure it works on your end as well)
dotnet format style --severity info
Can be compiled into a single exe using:
dotnet publish -p:PublishSingleFile=true -r win-x86 -c Release --self-contained false