search

henriquebastos / django-aggregate-if

Conditional aggregates for Django queries, just like the famous SumIf and CountIf in Excel.
MIT License
138 stars 17 forks source link

Reworked query.promote_joins() call to work with Django 1.5-1.6 and 1.7 ... #9

Closed end0 closed 10 years ago

end0 commented 10 years ago

...(which drops the unconditional arg)

end0 commented 10 years ago

In response to my own issue #8

henriquebastos commented 10 years ago

Nice! I'll merge it and check if the 1st issue still applies. After that I'll release 0.5 with you contribution. Tks a lot.

end0 commented 10 years ago

p.s. - I noticed Travis CI is running up to Django 1.6. May be useful to load 1.7rc2 on there just to make sure all tests still pass. I wasn't able to run your testsuite locally.

owais commented 10 years ago

@henriquebastos @end0 Thanks guys! Waiting on 0.5 release.

kawa-marcin commented 10 years ago

Hello, can I ask for merge it? Cheers

end0 commented 10 years ago

@henriquebastos Sorry to bother again, but can you complete the PR? Now that 1.7 is out, I'm working on a real project, and would prefer to use your version over my fork.

henriquebastos commented 10 years ago

I'm unifying this discussion on a new PR: https://github.com/henriquebastos/django-aggregate-if/pull/11