search

henriquemiranda / phononwebsite

Visualise lattice vibrations
http://henriquemiranda.github.io/phononwebsite/
BSD 3-Clause "New" or "Revised" License
83 stars 32 forks source link

Support for VESTA display-style #9

Closed ngaro closed 6 years ago

ngaro commented 6 years ago

By setting "vesta" to true/false in the VibCrystal class the display-style can now be switched between VESTA and the default (JMOL).

We'll leave the choice of implementation of the dropdown-box to you, so not to hinder your choice of web-layout.

This is written in cooperation with Annelinde Strobbe. Contact nikolas.garofil@uantwerpen.be or annelinde.strobbe@uantwerpen.be for more info.

henriquemiranda commented 6 years ago

Thanks a lot for this work. I added a combo box to select the Vesta style. I like the idea of having multiple styles so I changed the code a little bit so as to be possible to add more styles in the future. I understand the idea of averaging the colors for the bonds but I will try to implement a feature to have two separate colors for the bond (half-half).

ngaro commented 6 years ago

Thanks for merging our code, adding the possibility to choose the display and immediately updating the site !

The merged colors in the bond are by choice in our case. Feel free to change this to the "official" vesta displaystyle. We feared that a double-coloured bond might be too distracting, besides the wiggling of the atoms.