henriqueribeiro / cromwell

Scientific workflow engine designed for simplicity & scalability. Trivially transition between one off use cases to massive scale production environments
http://cromwell.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
10 stars 6 forks source link

Fix aws unit tests #39

Closed xquek closed 1 year ago

xquek commented 1 year ago

Hi @henriqueribeiro and @geertvandeweyer,

Thanks for maintaining the fork. This Pull request is to update the following tests to account for recent updates: These are changes to get the tests to compile. I also removed some trailing white spaces in AwsBatchJob.scala please do take a look and let me know if there is any issue! thanks

Replacing mockito-sugar with vanilla mockito

It looks like mockito-sugar was removed as a test dependencies. Use vanilla mockito instead.

Missing imports

I think this might be because the package renamed from cromwell.backend.impl.aws to cromwell.backend.impl.aws.io for AwsBatchJobPaths, AwsBatchWorkflowPaths,AwsBatchWorkingDisk`

Missing Args and imports

With the introduction of new EFS feature, there are some missing args AwsBatchJob and AwsBatchRuntimeAttributes