Scientific workflow engine designed for simplicity & scalability. Trivially transition between one off use cases to massive scale production environments
This is a PR for the awsBatchEvaluateOnExit feature.
Changes made
Using the same pattern for awsBatchRetryAttempts, I made the following changes:
Added awsBatchEvaluateOnExit as part of AwsBatchRuntimeAttributes
Addded AwsBatchEvaluateOnExitValidation and use if for creating jobs.
Updated retryStrategyBuilder to include evaluateOnExit value
Fixed assertAwsBatchRuntimeAttributesFailedCreation as it will always pass because fail is a throws a runtimeException.
Added various tests and has tested it on various manual run. Will continue testing it.
Discussion
I have kept awsBatchEvaluateOnExit as a separate run time attribute instead of combining it with awsBatchRetryAttempts as coercion of nested values between womtype and scala type can be tricky.
We are continuously testing it internally but will to to put up this PR to hear what you think - we were able to get it working by setting it as default-runtime-attribute as will as task level attribute.
I also noticed that i wasnt able to coerce the List of Map directly from Config to WomArray(WomMap(WomString, WomString)) so im have to add a additional method fromConfig for AwsBatchEvaluateOnExitValidation.
Hi @henriqueribeiro,
This is a PR for the
awsBatchEvaluateOnExitfeature.Changes made
Using the same pattern for
awsBatchRetryAttempts, I made the following changes:awsBatchEvaluateOnExitas part ofAwsBatchRuntimeAttributesAwsBatchEvaluateOnExitValidationand use if for creating jobs.retryStrategyBuilderto include evaluateOnExit valueassertAwsBatchRuntimeAttributesFailedCreationas it will always pass becausefailis a throws a runtimeException.Discussion
I have kept
awsBatchEvaluateOnExitas a separate run time attribute instead of combining it withawsBatchRetryAttemptsas coercion of nested values between womtype and scala type can be tricky.We are continuously testing it internally but will to to put up this PR to hear what you think - we were able to get it working by setting it as default-runtime-attribute as will as task level attribute.
I also noticed that i wasnt able to coerce the List of Map directly from Config to WomArray(WomMap(WomString, WomString)) so im have to add a additional method
fromConfigforAwsBatchEvaluateOnExitValidation.