search

henry-rodrick / hlsjs-ipfs-loader

A js-ipfs loader for the hls.js JavaScript HLS client
MIT License
60 stars 31 forks source link

Add feature dynamically updating m3u8 and .ts source file #15

Closed vaultec81 closed 4 years ago

vaultec81 commented 4 years ago

Detailed in #12 ping @moshisushi :)

henry-rodrick commented 4 years ago

Thanks! Will have a proper look at this over the weekend :)

A quick first observation tho: I'm not sure about ignoring the package-lock.json file. As far as I know, the lock file is supposed to be committed: https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5

vaultec81 commented 4 years ago

Yeah I saw that too. I saw that it wasnt committed in the first place so I decided not to add it. Generally speaking I haven't seen it committed alot in other projects.

vaultec81 commented 4 years ago

ping @moshisushi

henry-rodrick commented 4 years ago

@vaultec81 Sorry I've had family business to take care of and not had time to look into this. Would you like to be added as a collaborator to this repo?

vaultec81 commented 4 years ago

@moshisushi No worries. and sure thing.

henry-rodrick commented 4 years ago

@vaultec81 Cheers! Do you have an npm alias as well please so I can add you there as well?

vaultec81 commented 4 years ago

@moshisushi yes I do, the same as GitHub so vaultec81. Thanks.

henry-rodrick commented 4 years ago

@vaultec81 great, you're added! knock yourself out :)

balgarath commented 4 years ago

@vaultec81 was wondering if you have an example of this being used? I'm trying to puzzle out using this for an hls livestream over ipfs

Thanks!

vaultec81 commented 4 years ago

@balgarath Example use case would be in circumstances where you would want to actively update/live stream HLS chunks. Before this was merged, it was impossible to update a livestream on the fly. There still is a couple of things that need to be created for a full scale live streaming system to be viable. Eventual project to be worked on.