fix: upgrade for 0.34 - Githubissues

henry-rodrick / hlsjs-ipfs-loader

A js-ipfs loader for the hls.js JavaScript HLS client

MIT License

60 stars 31 forks source link

fix: upgrade for 0.34 #7

Closed alanshaw closed 5 years ago

alanshaw commented 5 years ago

JS IPFS v0.34 is coming out soon. It has breaking changes. This PR addresses those issues. I've tested this against v0.34.0-rc.1 in the browser video streaming example and it all works.

This PR also improves the code by actually streaming the file using catReadableStream over cat (which buffers content in memory).

alanshaw commented 5 years ago

ping @moshisushi - JS IPFS 0.34 is now out - it would be good to get this merged so it works with the latest version.

henry-rodrick commented 5 years ago

Thanks, looks good! Nice getting rid of the lodash dep. :)

Will get a new release out asap.

henry-rodrick commented 5 years ago

Tested and works fine! 0.1.3 published to npm. Thanks again!