Error should be exposed through events not just thrown.

henry-spanka / freeathome-api

Busch-Jaeger free@home API to control actuators

MIT License

45 stars 4 forks source link

Error should be exposed through events not just thrown. #10

Closed ZzAve closed 4 years ago

ZzAve commented 5 years ago

Whenever System-Access-Point throws an exception this is caught in application and handled there. However, it is handled because of a generic 'unhandledexception' block. This behaviour is discouraged by nodejs and will be deprecated soon.

I propose to extend the broadcast functionality of System-Access-Point. Let it expose both updates and errors, introduce typing and make integration with freeathome-api as a lib even simpler.

henry-spanka commented 5 years ago

Hi, you are right. You can open a PR for it if you like. Unfortunately I don't have much time at the moment to do this.

ZzAve commented 5 years ago

I haven't had the time to do this last week. This week I'll try and put in a PR!

henry-spanka commented 4 years ago

I think we can close this now? What do you think?

ZzAve commented 4 years ago

Jup! Fine with me