search

henry123-boy / SpaTracker

[CVPR 2024 Highlight] Official PyTorch implementation of SpatialTracker: Tracking Any 2D Pixels in 3D Space
Other
734 stars 25 forks source link

Bug in _compute_dense_tracks #16

Open jinlinyi opened 5 months ago

jinlinyi commented 5 months ago

Hi Yuxi,

Thanks for releasing this great project. The depth_predictor and video_depth variables are not used here, which causes error when using _compute_dense_tracks.

https://github.com/henry123-boy/SpaTracker/blob/0fcc1ad75bdd14ce4d2946d33630fac63e023fdd/models/spatracker/predictor.py#L100-L105

Additional request -- when you push new commits, could you just push without rebase? Otherwise it is hard for me to sync up my code with your latest change. Thank you!

Best, Linyi

henry123-boy commented 5 months ago

Hi Linyi, Thank you for your kind reminder. I have added the depth_predictor and video_depth there. For rebase, I appologize for that, cause I removed irrelevant history commits before. But the current version is clean already, so I guess you can re-clone and iterate based on the version right now. I am sorry for your inconvenience.

Best, Yuxi