Closed henry2004y closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
681f658
) 53.44% compared to head (f7e0c68
) 73.70%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Although not perfect, this PR at least accomplishes two things:
When I checked the recent TestParticleMakie CI runs, they all showed green while they actually failed.
Let's make a quick tagged version for this.
Although not perfect, this PR at least accomplishes two things:
- Replace GLMakie with CairoMakie in testing to avoid precompilation and test failure;
- Loosen the related package version limitation caused by GLMakie.
When I checked the recent TestParticleMakie CI runs, they all showed green while they actually failed.
Let's make a quick tagged version for this.
All checks of TestParticleMakie CI should have passed, are the failures you mentioned referring to those warnings?
Although not perfect, this PR at least accomplishes two things:
- Replace GLMakie with CairoMakie in testing to avoid precompilation and test failure;
- Loosen the related package version limitation caused by GLMakie.
When I checked the recent TestParticleMakie CI runs, they all showed green while they actually failed. Let's make a quick tagged version for this.
All checks of TestParticleMakie CI should have passed, are the failures you mentioned referring to those warnings?
Those warnings related to TestParticleMakie
are part of the testing itself.
105