Closed henry2004y closed 1 year ago
Merging #77 (a1d67f7) into master (ca04d35) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 61.41% 61.41%
=======================================
Files 5 5
Lines 368 368
=======================================
Hits 226 226
Misses 142 142
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
There is still one issue here, which is the warning in the log.
┌ Warning: cover file doesn't exists
│ cover_path = "/home/runner/work/TestParticle.jl/TestParticle.jl/docs/examples/simulations/../../figures/proton_ganymede_mhdepic.png"
└ @ DemoCards ~/.julia/packages/DemoCards/ZgH8l/src/generate.jl:358
This should be a bug in DemoCards
, and I have already submitted the relevant issue.
https://github.com/JuliaDocs/DemoCards.jl/issues/146
Additionally, there is another issue where all the examples have been moved from the 'examples' folder to 'docs', and the dependency has been changed to WGLMakie
. The slider on the web version cannot interact properly.
My question is, whether it is necessary to maintain a version of GLMakie
for some examples. In my teaching, I directly run the examples and introduce them through interaction.
There is one more strange thing, when running this command on my computer:
julia --project make.jl
There is a strange error in my log, which did not appear in the GitHub action.
Warning: failed to run `@example` block in src/examples/basics/demo_magneticmirror.md:14-109
│ ```@example demo_magneticmirror
│ using JSServe: Page # hide
│ Page(exportable=true, offline=true) # hide
│
│ using TestParticle
│ using TestParticle: getB_mirror
│ using OrdinaryDiffEq
│ using StaticArrays
│ using LinearAlgebra
│ using TestParticleMakie
│ using Printf
│ using WGLMakie
│
│ ### Obtain field
│
│ # Magnetic mirror parameters in SI units
│ const I = 20. # current in the solenoid
│ const N = 45 # number of windings
│ const distance = 10. # distance between solenoids
│ const a = 4.0 # radius of each coil
│
│ function getB(xu)
│ SVector{3}(getB_mirror(xu[1], xu[2], xu[3], distance, a, I*N))
│ end
│...
|...
│ f
│ ```
│ value = UndefVarError: `getB_mirror` not defined
└ @ Documenter.Expanders ~/.julia/packages/Documenter/H5y27/src/Utilities/Utilities.jl:34
Can I trouble you to help test and see if the same error occurs? @henry2004y
My question is, whether it is necessary to maintain a version of
GLMakie
for some examples. In my teaching, I directly run the examples and introduce them through interaction.
Even though all the examples can be run interactively by changing WGLMakie
to GLMakie
, this may indeed be a problem for users unfamiliar with the plotting packages. Actually you can also find that some of the figures are not interactive after adding the title and labels. For now let's add a note in the front page of the Examples section. I want to avoid demo code duplications.
Can I trouble you to help test and see if the same error occurs? @henry2004y
I have a similar issue yesterday. getB_mirror
is a recently added method (that lives in master but not in a release patch), so you need to use the master branch of TestParticle to make it work. What I did is
pkg> add TestParticle#master
After we register a new patch this is no longer an issue.
I found that there are some display issues with Democards
. This is how it looks in the version I generated locally.
It is different from the version of the documentation of Democards
with theme "grid". This should not be a problem with my network causing the CSS to not load correctly. May I ask if your local version has the same issue?
I have the same issue, which does not happen for my other package Vlasiator demo. Based on a quick scan the json files are identical...
Maybe we can ignore that for now, leave an issue and fix it later.
Move examples into docs with WGLMakie support. Handle #71 and #74.
With these changes, each example takes a separate page and generates < 21 MB html file. We won't have outdated demos anymore!