search

henry2004y / TestParticle.jl

Test particle tracing in electromagnetic field
https://henry2004y.github.io/TestParticle.jl/dev/
MIT License
14 stars 3 forks source link

Make TestParticleMakie as an extension #92

Closed TCLiuu closed 8 months ago

TCLiuu commented 8 months ago
  1. Making TestParticleMakie as an extension #88
  2. Fix a bug #81
TCLiuu commented 8 months ago

Should we remove TestParticleMakie from registry?

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c6a615c) 63.73% compared to head (b247145) 70.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #92 +/- ## ========================================== + Coverage 63.73% 70.94% +7.21% ========================================== Files 6 9 +3 Lines 386 530 +144 ========================================== + Hits 246 376 +130 - Misses 140 154 +14 ``` | [Files](https://app.codecov.io/gh/henry2004y/TestParticle.jl/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hongyang+Zhou) | Coverage Δ | | |---|---|---| | [ext/TestParticleMakie.jl](https://app.codecov.io/gh/henry2004y/TestParticle.jl/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hongyang+Zhou#diff-ZXh0L1Rlc3RQYXJ0aWNsZU1ha2llLmps) | `100.00% <ø> (ø)` | | | [ext/interactive.jl](https://app.codecov.io/gh/henry2004y/TestParticle.jl/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hongyang+Zhou#diff-ZXh0L2ludGVyYWN0aXZlLmps) | `84.14% <ø> (ø)` | | | [src/TestParticle.jl](https://app.codecov.io/gh/henry2004y/TestParticle.jl/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hongyang+Zhou#diff-c3JjL1Rlc3RQYXJ0aWNsZS5qbA==) | `91.81% <ø> (ø)` | | | [ext/typerecipes.jl](https://app.codecov.io/gh/henry2004y/TestParticle.jl/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hongyang+Zhou#diff-ZXh0L3R5cGVyZWNpcGVzLmps) | `98.36% <50.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TCLiuu commented 8 months ago

There is still an issue. Should we merge the testCI of TestParticlemakie and TestParticle? If not, the coverage report will have some strange problems when the testCI of TestParticlemakie does not run, as it occurred in those PRs before.

henry2004y commented 8 months ago

Should we remove TestParticleMakie from registry?

If I remember correctly, there is currently no way of removing a package from the registry. We can simply mark it as archived and leave it there.

There is still an issue. Should we merge the testCI of TestParticlemakie and TestParticle? If not, the coverage report will have some strange problems when the testCI of TestParticlemakie does not run, as it occurred in those PRs before.

I think we should merge the visual tests into the main tests. With CairoMakie and the CI cache system, this should not add too much test time. See an example here. They list CairoMakie as a test Project.toml dependency and always import it. I saw your approach of checking args in runtest.jl. This is also good.

henry2004y commented 8 months ago

This is almost done! Nice job!