henry232323 / Pesterchum-Discord

A Discord client mimicking the Pesterchum chat client from Homestuck, Uses a lot of code from my Pesterchum Client
MIT License
27 stars 3 forks source link

Deleted Messages Not Registered, and a Few Minor Issues #16

Open greenhouseGenesis opened 4 years ago

greenhouseGenesis commented 4 years ago

now that the recent update has allowed me to look closer at the program im able to spot a few issues that are, while less detrimental to the function of the program, still exist!

the main issue, and the only one that needs solving in my eyes, is that messages that are deleted from discord arent removed from the pesterchum client. this wouldnt be a huge issue if not for certain bots like pluralkit, which function by deleting messages from channels and re-sending them under different names; in the pesterchum client, this becomes kind of a massive cluttered mess really quickly!!!


there are a few other minor issues here, that don't need fixing quite as badly but would be good quality of life:

henry232323 commented 4 years ago

Are you able to verify that the crashes are caused by tabbing into Discord client specifically?

henry232323 commented 4 years ago

I've solved the last three in the most recent update, but I really have no idea what would cause the first one or how to reproduce it https://github.com/henry232323/Pesterchum-Discord/releases/tag/v1.3.10

greenhouseGenesis commented 4 years ago

just looking into it now, sorry for the delay!!! oddly enough, i cant recreate it, either; it seemed so consistent BEFORE i posted this, but i guess i was mistaken! something else must have been causing problems. it just crashed twice as i type this, both times when i was tabbed into a different program (firefox and snipping tool, respectively), and i havent a clue why, but ill make sure to make another issue if i can get it more consistent.


as for the discord formatting: it works with italics and multi-line codeblocks perfectly, completely ignores bold but still removes the double-asterisks (which is fine, better than leaving in the symbols for sure), but doesnt work for strikethrough, single-line codeblocks, and underline, nor do backslashes properly cause it to ignore formatting. underline formatting causes it to do something COMPLETELY different, actually - ill add an image of the results of playing with discord formatting below. it also doesnt work for spoilers, though i cant imagine why or how those would be supported in this client, but it seems worth mentioning.

image


also, i know i formatted the original issue post really weirdly and terribly, and i apologize for that, but did you note the issue with deleted messages not being properly removed from memos?


also of note (though i can make a new issue for this if that would be better): the auto-updater seems to be downloading the OSX version, even though i use windows. easily circumvented by just... downloading it straight from here, but seemed noteworthy!

henry232323 commented 4 years ago

Regarding surrounding a message in , its meant to mimic the original /me functionality. When you send a message in old pesterchum with /me it formats like that, in discord when you send a message with /me it will surround it with to make it italics. If the bold doesn't show up it probably wont be fixable. I don't have any good way to manage spoilers, but I can make ` show up the same as ```. I'll get strikethrough implemented though. Using \ escapes will be hard to implement but I think I can do it. Deleting messages might require a bit of an overhaul for how messages are handled, we'll see how I can do that.

henry232323 commented 4 years ago

As for the crashes, do they happen as you tab out or randomly while tabbed out?

greenhouseGenesis commented 4 years ago

sorry for the delayed response!! from what i recall, its been randomly, but im testing it right now just in case. if i get any conflicting information on that, ill make another post here, but unless my amnesia is fucking with me (as it is want to do ://) its pretty random.

EDIT: just left it running while tabbed into firefox while i went to go eat, and it randomly crashed after a few minutes, so theres confirmation of that