henrybear327 / Proton-API-Bridge

A third-party, open-source Proton API bridge (mainly focusing on Drive for now)
MIT License
83 stars 5 forks source link

Address SHA1 case issue #27

Closed tomekit closed 2 months ago

tomekit commented 6 months ago

Address SHA1 case issue.

Related https://github.com/henrybear327/Proton-API-Bridge/issues/21 and https://github.com/rclone/rclone/issues/7345#issuecomment-1821463100

I can't exactly reproduce when Proton returns uppercase SHA1, but it seems that if we set all SHA1 to lower case it should unify the way it's handled later in Rclone: https://github.com/rclone/rclone/blob/c5ff5afc21e818835e953eb424c8744daa1eb49e/fs/operations/operations.go#L119

ncw commented 2 months ago

You could instead / as well fix this in rclone @tomekit

https://github.com/rclone/rclone/blob/1a9e6a527d0f13f4fc047a67570a4a943fdd16bb/backend/protondrive/protondrive.go#L849

@henrybear327 would you consider adding me as a maintainer for this repo and henrybear327/go-proton-api then I can merge obviously correct stuff like this when you don't have time?

Or you might want to consider transferring both the repos into the rclone organization? Then any of the rclone maintainers can help out. Drop me an email nick@craig-wood.com if you want to discuss more.

henrybear327 commented 2 months ago

You could instead / as well fix this in rclone @tomekit

https://github.com/rclone/rclone/blob/1a9e6a527d0f13f4fc047a67570a4a943fdd16bb/backend/protondrive/protondrive.go#L849

@henrybear327 would you consider adding me as a maintainer for this repo and henrybear327/go-proton-api then I can merge obviously correct stuff like this when you don't have time?

Or you might want to consider transferring both the repos into the rclone organization? Then any of the rclone maintainers can help out. Drop me an email nick@craig-wood.com if you want to discuss more.

Hey @ncw,

I have dropped you an email :)

Have a nice weekend!

Henry