search

henrycatalinismith / ppl

The command line address book
http://henry.catalinismith.com/ppl/
Other
300 stars 18 forks source link

UTF-8 support for file names #46

Closed axelGschaider closed 10 years ago

axelGschaider commented 10 years ago

I know it's bad habit to use special characters in file names. But sometimes import-/export-tools create file names with non-english characters.

The problem is that ppl crashes with these file names.

STEPS TO REPRODUCE -) copy paste this to your console: ppl add franz_viehböck "Franz Viehböck" -) when running ppl ls you will get this error: ppl: incompatible character encodings: ASCII-8BIT and UTF-8

NOTE if you add the contact with this command ppl add franz_viehboeck "Franz Viehböck" (still special character in the name but not in the contact descriptor) you don't have any problems.

I would like to see full UTF-8 support for file names (or <contact> fields as you call them)

henrycatalinismith commented 10 years ago

Hey man, glad to hear this thing is still proving useful to you despite these little i18n issues. I've certainly learned a lot about Ruby character encoding issues from working with you on this project. I just wanted to let you know that I have fixes ready for this and issue #45. My response time hasn't been as quick as I'd normally like though, for which I apologise. Been busy! :)

axelGschaider commented 10 years ago

never mind the response time. I don't get money from github either :)

updated ppl. Fixed. May I have the honor to close this issue?