search

henrychavez / nativescript-bottom-navigation

Nativescript plugin for Android & iOS to have the bottom navigation bar of Material Design
Apache License 2.0
58 stars 18 forks source link

Fixed Typescript Declaration File #76

Closed keerl closed 5 years ago

keerl commented 5 years ago

Just updated from 1.5.1 to 2.0.3 and received some new errors complaining about type definitions. Figured this was simple enough to fix and updated index.d.ts

ERROR in node_modules/nativescript-bottom-navigation/index.d.ts(21,3): error TS2416: Property 'activeColor' in type 'BottomNavigationBar' is not assignable to the same property in base type 'BottomNavigationBarBase'.
  Type 'string' is not assignable to type 'Color'.
node_modules/nativescript-bottom-navigation/index.d.ts(22,3): error TS2416: Property 'inactiveColor' in type 'BottomNavigationBar' is not assignable to the same property in base type 'BottomNavigationBarBase'.
  Type 'string' is not assignable to type 'Color'.
node_modules/nativescript-bottom-navigation/index.d.ts(23,20): error TS2304: Cannot find name 'Color'.
node_modules/nativescript-bottom-navigation/index.d.ts(46,22): error TS2304: Cannot find name 'EventData'.