search

henryclever / FleX_PyBind11

Python bindings for the Nvidia FleX simulator
Other
13 stars 1 forks source link

How to define FleX_ROOT? #1

Closed alantrrs closed 5 years ago

alantrrs commented 5 years ago

Hi, I'm doing a Dockerfile for this (happy to make a PR if you're interested), but I'm running into an issue when compiling. Seems like FindFlex.cmake is not finding the FleX_PATH since it's not reading the FleX_ROOT hint here. It works fine if I just hardcode the path, but I'm wondering how are you passing it when compliling via pip install ./bindings?

henryclever commented 5 years ago

Hello,

I hard coded this in my CMakeLists.txt file. It's on line 6:

if (NOT DEFINED FleX_ROOT)
    set(FleX_ROOT ~/git/FleX_PyBind11)
endif()

If your root FleX path is somewhere else or your FleX folder is name something else (which it probably is), just edit that line accordingly in CMakeLists.txt. I suppose I could have made some auto-finder function, but I haven't gotten around to it.

Pardon my stupidity, but what is a PR? (background in Mech E., not CS, so I have knowledge gaps!) But that seems like something I'd be interested in.

-Henry C.

alantrrs commented 5 years ago

ah, got it. thanks!

By PR I meant pull-request, just some GitHub lingo :). I'll submit it in a bit.

alantrrs commented 5 years ago

PR submitted here: https://github.com/henryclever/FleX_PyBind11/pull/2