search

henrycode460 / Portfolio-Mobile-Version-Skeleton

This repositor contains setup and mobile version skeleton of a Portfolio
3 stars 1 forks source link

Online Version #7

Open henrycode460 opened 2 years ago

henrycode460 commented 2 years ago
prolajumokeoni commented 2 years ago

Hi @henrycode460 Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

✔️ No linter errors ✔️ Github flow was correctly used ✔️ Good design

Required Changes ♻️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

henrycode460 commented 2 years ago

Hi dear,

I added the link within the Readme , I can see it from my computer that is there.

On Mon, May 2, 2022, 1:02 PM Oni Olajumoke Priscilla < @.***> wrote:

Hi @henrycode460 https://github.com/henrycode460 Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there! Highlights

✔️ No linter errors ✔️ Github flow was correctly used ✔️ Good design Required Changes ♻️

  • Kindly add the link of your successfully deployed website to your readme file, this will make your readme more professional 👍🏿

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification @prolajumokeoni https://github.com/prolajumokeoni.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.

— Reply to this email directly, view it on GitHub https://github.com/henrycode460/Portfolio-Mobile-Version-Skeleton/issues/7#issuecomment-1114820556, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXCDEXZLSIWLWCO4WLBF5CDVH7G5BANCNFSM5U346WCA . You are receiving this because you were mentioned.Message ID: @.*** .com>

prolajumokeoni commented 2 years ago

Hi @henrycode460

When I clicked on the link, It took me to project requirement link

henrycode460 commented 2 years ago

OK , I understand. I work on it by creating another branch. And I just got approved.

Thanks

On Mon, May 2, 2022, 1:27 PM Oni Olajumoke Priscilla < @.***> wrote:

Hi dear, I added the link within the Readme , I can see it from my computer that is there. … <#m-7268134974840714507> On Mon, May 2, 2022, 1:02 PM Oni Olajumoke Priscilla < @.> wrote: Hi @henrycode460 https://github.com/henrycode460 https://github.com/henrycode460 https://github.com/henrycode460 Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there! Highlights ✔️ No linter errors ✔️ Github flow was correctly used ✔️ Good design Required Changes ♻️ - Kindly add the link of your successfully deployed website to your readme file, this will make your readme more professional 👍🏿 Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification @prolajumokeoni https://github.com/prolajumokeoni https://github.com/prolajumokeoni https://github.com/prolajumokeoni. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. ------------------------------ As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s https://airtable.com/shrQAqnBwek5a0O0s. — Reply to this email directly, view it on GitHub <#7 (comment) https://github.com/henrycode460/Portfolio-Mobile-Version-Skeleton/issues/7#issuecomment-1114820556>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXCDEXZLSIWLWCO4WLBF5CDVH7G5BANCNFSM5U346WCA https://github.com/notifications/unsubscribe-auth/AXCDEXZLSIWLWCO4WLBF5CDVH7G5BANCNFSM5U346WCA . You are receiving this because you were mentioned.Message ID: @. .com>

When I clicked on the link, It took me to project requirement https://github.com/microverseinc/curriculum-html-css/blob/main/portfolio/5_deploy.md link

— Reply to this email directly, view it on GitHub https://github.com/henrycode460/Portfolio-Mobile-Version-Skeleton/issues/7#issuecomment-1114880968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXCDEXZ37DRS4XODNZDDZUTVH7J53ANCNFSM5U346WCA . You are receiving this because you were mentioned.Message ID: @.*** .com>