henryj / Voice-Encounter-Mods

Voice Enhanced DBM addon for World of Warcraft
13 stars 6 forks source link

VEM Update for 6.0.2 #28

Closed Zerat0 closed 9 years ago

Zerat0 commented 10 years ago

Hello ,

I would like to thank you Iceoven for this very usefull addon tho as it seems there are many request to be updated for patch 6.0.2. Hope we will see it update asap :)

Yours , Zerat0

Velalen commented 10 years ago

Dear Iceoven, You had stated in Curse description you do not check it very often for requests, bugs, etc. So I am reaching out to you here on Github, with the support of MANY (check Curse's page) to continue with your AMAZING Addon, VEM! If you have no intent, due to time, family or just no interest, would you be willing to give the reigns to someone else to continue with this addon? There are sooooo many of us that absolutely LOVE, LOVE, LOVE this addon. Please consider allowing someone else to take over for you. Someone, who will give you continued credit for your work, will keep it mostly original, unless something else can be added (which seems impossible) to make it even more spectacular than it already is. Your Fan base is imploring you to either return, or give lead to another.
We love the work you have done, and I'm certain based off of posts, there would be support in the form of donations to keep this addon alive. I hope this reaches you in a semi timely manner and with some luck an update for VEM will reach us for the new xpan Warlord's of Draenor will see it sitting in the addons list. I for one, can not wait! Excellent! addon, innovative and just amazing! Please consider the above mentioned options for continuation of this great tool for raiding!

MUCH LOVE <3 a HUGE fan.....Velalen WoW Veteran 10yrs and counting!

trueleader commented 10 years ago

Hi, I just startet a Pull-Request for the 6.0.2 update. It only restores the functionality, and does not add Instance-Support for WoD.

Mini-Dragon commented 10 years ago

Lots of work to do. Change mp3 to ogg is not enough. New newsound(class) format, and dbm_arrow problem... core is a big problem. I modify the SoO mod and core, but still lots of bug in SOO mod. Check this: https://gitcafe.com/Mini_Dragon/DBM (Voice by Xia Yike)

BTW, I have party-WoD mod. use my sound class format. https://github.com/Mini-Dragon/VEM-Party-WoD

trueleader commented 10 years ago

Had not changed sound format only. Updated GUID and some SpellInfo usage. Checked LFR SoO part 2 only yet ... Monday is Mythic raid where I can see other errors :/

Mini-Dragon commented 10 years ago

isHeroic25() and isHeroic10() should be replaced by isMythic() and isMythic is only supported by 6.0 DBM core.

trueleader commented 10 years ago

Changed conditions as suggested. IsMythic was already added in previous commit

henryj commented 10 years ago

Sorry guys. As you may know, I just translate and manage this addon for the original Chinese author. As he's still AFK at the moment my hands are tied. So if you guys are able to fix it for 602, I'm happy to release it onto Curse. I don't have a WoW client now, so I'll accept all pull requests and you guys let me know when it comes to a stage we can release. Thanks all.

Mini-Dragon commented 10 years ago

@trueleader did you find some problems in dbm-hud? Like in sha of pride, you will see a black box instead of an arrow.

And it looks like Henry fixed all the raid condition problems. However i think core shoule be updated but it's a big project.

Velalen commented 10 years ago

do I need DBM now to run VEM? I love VEM, but sadly I do not know coding or how to create addons or I would take over your wonderful addon. My hope is that someone responsible, and knowledgable will be able to continue your work...and mostly keep it as is. It's pretty perfect they way it was created. I don't see need for improvements, other than to correct errors/bugs. I made sure the gaming community knows I am able to speak to you and that a developer of your caliber should contact you, at Github, to further this marvel we know as VEM :) I hope someone read my comments on how to find you! Thank You very much for responding, it has meant a lot :) On Oct 18, 2014 3:29 PM, "Mini He" notifications@github.com wrote:

@trueleader https://github.com/trueleader did you find some problems in dbm-hud? Like in sha of pride, you will see a black box instead of an arrow.

— Reply to this email directly or view it on GitHub https://github.com/henryj/Voice-Encounter-Mods/issues/28#issuecomment-59626630 .

Mini-Dragon commented 10 years ago

@Velalen Hi. You don't need DBM to run VEM. We will fix it. It's a huge project.

Velalen commented 10 years ago

I know, and I wish I could help, but I would be of no use to you other than to be your "cheer leader" and continue to let you (both) know how much the gaming community LOVES your work. It really is great...and I mean that sincerely. If you need assistance, I would be glad to try snd help by putting "feelers" out there for other Devs to contact you, so it's not solely on your shoulders? Let me know :) On Oct 18, 2014 6:04 PM, "Mini He" notifications@github.com wrote:

@Velalen https://github.com/Velalen Hi. You don't need DBM to run VEM. We will fix it. It's a huge project.

— Reply to this email directly or view it on GitHub https://github.com/henryj/Voice-Encounter-Mods/issues/28#issuecomment-59631314 .

Gitanj commented 10 years ago

There's someone who uploaded a VEM fix at Curse (within the discussions). Some are saying it works.

Mini-Dragon commented 10 years ago

@Gitanj I noticed that and working on it now.

Gitanj commented 10 years ago

@Mini-Dragon Thanks! Echoing what others have said, VEM really is a go-to addon for me now. Once I've used it, I've never gone back to DBM and BigWigs.

trueleader commented 10 years ago

@Mini-Dragon: Just tested it: have normal arrows Added a slashcommand to check at my fork /vem hud

trueleader commented 10 years ago

Finished Heroic today without any problems. Only spoils combat doesn´t end automatically - maybe this isn´t a problem of VEM but blizzard, because the boss energy counter does not reset in second room too - neither without any addons

Velalen commented 10 years ago

yes, it could be Blizz...game is still buggy, hoping all bugs will be work out after WoD goes live. Until then lots of tweaks I'd imagine sadly On Oct 19, 2014 2:56 PM, "trueleader" notifications@github.com wrote:

Finished Heroic today without any problems. Only spoils combat doesn´t end automatically - maybe this isn´t a problem of VEM but blizzard, because the boss energy counter does not reset in second room too - neither without any addons

— Reply to this email directly or view it on GitHub https://github.com/henryj/Voice-Encounter-Mods/issues/28#issuecomment-59660409 .

Mini-Dragon commented 10 years ago

I am contacting with henry and try to figout what is going on here.

Velalen commented 10 years ago

sounds like a plan :) hope he has some insight for you :) On Oct 19, 2014 8:22 PM, "Mini He" notifications@github.com wrote:

I am contacting with henry and try to figout what is going on here.

— Reply to this email directly or view it on GitHub https://github.com/henryj/Voice-Encounter-Mods/issues/28#issuecomment-59672117 .

henryj commented 10 years ago

Hey, mini dragon, I've merged your core as much as I can. Since I don't have a WOW client, I guess you guys will have to test and fix bugs etc. Pretty sure there will be bugs... as I can see so many changes... I might merged something I shouldn't and missed something I should...

Mini-Dragon commented 10 years ago

Hi please merge my fork and update http://wow.curseforge.com/addons/astrolabe/ and you can update any other file in core and git except toc. And you have to rename soo mod name as soov2

henryj commented 10 years ago

I think trueleader has updated astrolabe and all the other files in core are identical. As for soov2, I can see that you're using your own SoundMMPath which is set statically to your version of yike voice. And for VEM we need to use VEM.Options.CountdownVoice to keep all the other voice packs usable. I've converted all the other voice packs to ogg btw.

So if you can help with a version utilizing VEM.Options.CountdownVoice would be great.

Thoughts?

Mini-Dragon commented 10 years ago

@henryj Hi. Please merge https://github.com/Mini-Dragon/VEM-Party-WoD into your master. Using VEM.Options.CountdownVoice now. Someone please check my code again to make sure that there has no typo or something wrong.

BTW, 4 new sound files should be added into the sound list. I will write down the line for you just in few days. I will contact Yike to record the Chinese.

Have a good day guys.

henryj commented 10 years ago

Thanks @Mini-Dragon. I've created a branch for our WoD code. https://github.com/henryj/Voice-Encounter-Mods/tree/WoD

Your code has been merged onto that branch and I've cleaned up the MoP part as well. BTW, I've replaced the word 'DBM' in your code with 'VEM' as 'DBM' is a trademark and we cannot use it anywhere in our code.

The master will have both MoP and WoD for a while until WoD officially releases. Anyone interested in testing please download the branch.

Let me know when you have the voice details. I'll manage the English part. Thanks again.

Velalen commented 10 years ago

no, ty......sooooo excited!!!! ♥ On Oct 25, 2014 8:21 PM, "Henry J" notifications@github.com wrote:

Thanks @Mini-Dragon https://github.com/Mini-Dragon. I've created a branch for our WoD code. https://github.com/henryj/Voice-Encounter-Mods/tree/WoD

Your code has been merged onto that branch and I've cleaned up the MoP part as well. BTW, I've replaced the word 'DBM' in your code with 'VEM' as 'DBM' is a trademark and we cannot use it anywhere in our code.

The master will have both MoP and WoD for a while until WoD officially releases. Anyone interested in testing please download the branch.

Let me know when you have the voice details. I'll manage the English part. Thanks again.

— Reply to this email directly or view it on GitHub https://github.com/henryj/Voice-Encounter-Mods/issues/28#issuecomment-60502148 .

Mini-Dragon commented 9 years ago

Check my github for more details

modified: Auchindoun/Nyami.lua modified: Auchindoun/ProtectorOfAuch.lua modified: BloodmaulSlagMines/Roltall.lua modified: EverBloom/Yalnu.lua modified: IronDocks/Skulloc.lua

Filename,Chinese,English 153247.ogg,陨石快躲,Meteor run! findshelter.ogg,快找掩体,find shelter findshadow.ogg,快进阴影,find shadow findshield.ogg,快找盾牌,find shield 169613.ogg,快踩小花,stomp flowers

Chinese was done by Yike Xia

henryj commented 9 years ago

Thanks @Mini-Dragon. Are you still maintaining your version on gitcafe? I assume that was the one which has the latest updates? If so, I can just pull things from there. Then you may have your focus on the major part and I'll find my way to get the English version done.

Mini-Dragon commented 9 years ago

Both repo have the same idea but use different functions. I use soundmm class and yike:play in gitcafe, which is more flexable in programming. In github, I use old style functions and classes but have same idea.