henryjeff / portfolio-website

https://henryheffernan.com
MIT License
973 stars 149 forks source link

Cursor position on Firefox completely wrong for CSS Plane #6

Closed henryjeff closed 2 days ago

henryjeff commented 2 years ago

The cursor position for the Iframe containing the inner website is totally wrong, and this is due to an underlying bug in Firefox that has apparently existed since 9 years ago and gone through many regressions. Here are some resources I found:

Stack Overflow post #1 Stack Overflow post #2 Random Forum Bugzilla #1 Bugzilla #2

For now this issue will remain open, however I am just blocking all Firefox users with the loading screen for the time being.

benjibee commented 2 years ago

I know this particular site doesn't play well as a result of this bug but don't you think urge you to use a different browser could be better phrased as urge you to use a different browser while viewing this site ? Or do you really recommend people don't use Firefox as their browser?

Just sayin' 🤷

nkoehring commented 2 years ago

Honestly, I calculating the actual position is not so hard to call it "an equally complicated workaround". :shrug:

henryjeff commented 2 years ago

@benjibee Yes, I realize now how poor the wording is. I just pushed a fix that is more aligned with my original intentions. I am an avid FireFox user and supporter, I wasn't trying to urge people not not use the browser, but just let them know if they wanted to view the site, they needed to use a different browser. Thank you for calling this to my attention.

Link to the fix

Thanks again, and I apologize for the confusion. I feel like such an idiot now lol.

henryjeff commented 2 years ago

@nkoehring I'd love for you to elaborate if you think you might have a fix. When I first came across this bug it was before actually adding interactions into my site, and also when I was planning on completely replacing the users cursor with a custom one inside of the iframe. Set on getting the custom cursor to work, my focus at the time was to get proper positional coordinates for mouse events inside of the iframe. When testing on FireFox I noticed the bug for the first time. I tried to fix it for a good few days, but ultimately felt that working any more was doing more harm to the project than good. I added this error, created the issue, and moved on. In light of this bug it also killed any motivations I had to make a custom cursor, which in hindsight was definitely a good move.

As I have tested my site on every browser I can get installed on my Mac, FF remains the only one with this issue. The issue now is in essence the same as it was when I first discovered it, but is noticeable just by the fact that all interactions on the iframe plane are offset by a seemingly random (but definitely not random) amount of pixels.

For anyone in this thread who wants to see how the website works with the bug, you can visit the site with the ?debug flag and it will skip the error. Thanks!

https://www.henryheffernan.com/?debug

benjibee commented 2 years ago

@henryjeff I thought that might be the case! I'm just particularly protective of Firefox, especially in relation to Google Chrome! No need to feel like an idiot about it, though, I think I got what you meant. I develop in Firefox but always have to check it in Google Chrome as well… let's just be happy it's not like "the good 'ol days" of IE, and the like.

Also I should point out your website is a masterpiece and genius, so there's that. Best of luck with the job hunt!

kumavis commented 5 months ago

the website seems to work correctly on firefox 121.0 (linux)

Lana-chan commented 3 months ago

could not see an issue browsing the debug website and playing doom on it on firefox 124.0.1 64-bit under windows 10.

nclm commented 3 months ago

https://www.henryheffernan.com/?debug

Trying this on Firefox 125.0b4 (64-bit) on Mac and it seem to work very well.

nkoehring commented 3 months ago

Works well on Firefox 123 (64bit Linux) image

Adhamhossam000 commented 1 month ago

Hi I downloaded the inner website repo and when I run npm i and start it shows a blank white screen is there any solution to it?

irelephantT commented 1 week ago

It seems to be working perfectly on firefox 126.0.1 on windows 10.

henryjeff commented 2 days ago

Pushed a fix to remove the error, thanks everyone in this thread, sorry for not doing this sooner lol! (commit: ad58405 )