henryjfry / repository.thenewdiamond

9 stars 4 forks source link

Nexus issue #13

Closed JayDee696969 closed 1 year ago

JayDee696969 commented 1 year ago

Hello, just letting you know, extendedinfo is not working on Android OS in the latest Kodi Nexus. It seems to be working fine on Windows and Linux, but does not open he info if on Android. To reproduce: Open Diamond Extended Info, Click ALL Movies, or All TV, then click on one of the titles. It does not advance to the Info dialog, just stays "Working". You can press the context on the title and click Play to bring up the TMDBH players.

JayDee696969 commented 1 year ago

Has something to do with the PIL. ImportError: cannot import name'_imaging' from resources.PIL

henryjfry commented 1 year ago

PIL from within the addon should only be called if it isnt available from within Kodi. And it should be available in kodi. Before PIL issues havent been strictly speaking diamond related.

From what I recall last time the person had installed a PIL module from the diamond repository (not sure if it was mine or not, i think it was the previous diamond repo). But anyway if you try and install it as a module it doesnt work, as its actually a dummy module which is supposed to be a wrapper I think for the actual PIL module? So if you had tried installing a PIL module that could be the source of your issues?

But let me know if its still an issue, i just pushed a big update too. I'd need the error from the log before I could hazard any further guesses.

But PIL should just work.

henryjfry commented 1 year ago

So i tried installing Nexus on Android and trying Diamondinfo and I got the PIL error too. So im pretty sure my workaround install of:

/.kodi/addons/script.extendedinfo/resources/PIL/ /.kodi/addons/script.extendedinfo/resources/PIL2/

Isnt working on Nexus because of a different version of Python?

In my PIL there is:

/.kodi/addons/script.extendedinfo/resources/PIL/_imaging.cpython-37m-arm-linux-gnueabihf.so /.kodi/addons/script.extendedinfo/resources/PIL/_imagingcms.cpython-37m-arm-linux-gnueabihf.so /.kodi/addons/script.extendedinfo/resources/PIL/_imagingft.cpython-37m-arm-linux-gnueabihf.so /.kodi/addons/script.extendedinfo/resources/PIL/_imagingmath.cpython-37m-arm-linux-gnueabihf.so /.kodi/addons/script.extendedinfo/resources/PIL/_imagingmorph.cpython-37m-arm-linux-gnueabihf.so

While the Kodi nexus apk i just downloaded is going to be python 3.9?

So i think dont use nexus for now.

JayDee696969 commented 1 year ago

Kodi 20 is now final, so hopefully we could figure this out. Looks like Kodi 20 final uses python 3.8.

henryjfry commented 1 year ago

Ahh could be a version issue

https://pillow.readthedocs.io/en/stable/installation.html

from PIL.Image import core as _imaging

I'll maybe get a chance to try that and see what happens

In the meantime if you could give it a go if that's something you know how to do?

JayDee696969 commented 1 year ago

Ill give it a shot a little later

henryjfry commented 1 year ago

It's an easy fix actually.

You just need to add script.module.pil as a dependency in addon.xml

Just pushed an update, should come through shortly

JayDee696969 commented 1 year ago

Beautiful! Thank you!!

henryjfry commented 1 year ago

Updated to include dependency