henryjfry / repository.thenewdiamond

9 stars 4 forks source link

Extendedinfo no longer Bingie Mod after upgrade from 2.03 to 2.20 Omega #25

Open minhgi opened 1 month ago

minhgi commented 1 month ago

I get this error clicking on "Extended Info" button. Seem like it links to TheMovieDB Helper rather than Diamond ExtendedInfo. You have any suggestions to fix it? I can do light editing to python script if I have to fix this issue. 2024-05-11_174917

henryjfry commented 4 weeks ago

I believe the change you need to make is in the file here:

/xml/IncludesDialogVideoInfo.xml

                            <!--Extended Info Button-->
                            <label>31269</label>
                            <width>285</width>
                            <height>40</height>
                            <align>center</align>
                            <textoffsetx>0</textoffsetx>
                            <visible>Skin.HasSetting(videoinfo_button_extendedinfo)</visible>
                            <onclick condition="!System.HasAddon(script.extendedinfo)">RunPlugin(plugin://script.extendedinfo)</onclick>
                            <onclick condition="System.HasAddon(script.extendedinfo) + $EXP[IsMovieDBType]">RunScript(script.extendedinfo,info=extendedinfo,dbid=$INFO[ListItem.DBID],name=$INFO[ListItem.Title])</onclick>
                            <onclick condition="System.HasAddon(script.extendedinfo) + $EXP[IsTvShowDBType]">RunScript(script.extendedinfo,info=extendedtvinfo,dbid=$INFO[ListItem.DBID],name=$INFO[ListItem.TvShowTitle])</onclick>
                            <onclick condition="System.HasAddon(script.extendedinfo) + [String.IsEqual(ListItem.DBTYPE,season) | String.IsEqual(ListItem.Property(DBTYPE),season)]">RunScript(script.extendedinfo,info=seasoninfo,tvshow=$INFO[ListItem.TvShowTitle],season=$INFO[ListItem.Season],silent=True)</onclick>
                            <onclick condition="System.HasAddon(script.extendedinfo) + $EXP[IsEpisodeDBTypeNoFallback]">RunScript(script.extendedinfo,info=extendedepisodeinfo,dbid=$INFO[ListItem.DBID],tvshow=$INFO[ListItem.TvShowTitle],season=$INFO[ListItem.Season],episode=$INFO[ListItem.Episode],silent=True)</onclick>
                        </control>
                        <control type="button" id="112">

However this version in the repo:

https://github.com/AchillesPunks/repository.bingie.mod/blob/3847dbb6b58dc33885d34cb9cb46b4e6b83a1772/xml/IncludesDialogVideoInfo.xml#L393

Appears to use extendedinfo so im not sure what the version you are using might be doing

I should note that the screen shot you included has the "Trakt Manager" button which is a tmdbhelper thing, so are you sure you arent on a tmdbhelper info screen? That would explain the tmdbhelper error.

The kodi logs should give an indication of the XML file which is being loaded when you select that screen so that may help you narrow down whats going on.

minhgi commented 3 weeks ago

Yeah. When I choose to "Credit and More Info" replace with "Extended Info", the button link to TheMovieBD Helper rather the DiamodInfo. Not sure what other options to switch unless Bingie Mode is coded to use TheMovieDB Helper rather than the generic script.extendedinfo. Currently using BingieMod version 2.20.

image 2024-06-09_180326

henryjfry commented 3 weeks ago

Can you send me a link to the repo? The one i linked to isnt the same version I dont think

minhgi commented 3 weeks ago

This the link to the official Kodi Bingie Mod thread. Latest version 2.20 for Omega. https://forum.kodi.tv/showthread.php?tid=355993

TBM repo: https://achillespunks.github.io/repository.titan.bingie.mod/repository.titan.bingie.mod/

henryjfry commented 3 weeks ago

Ok so it appears that dispite what it might say on the label and in the settings that the extendedinfo functionality was removed in:

Update 2.1.0 https://github.com/AchillesPunks/skin.titan.bingie.mod/commit/2953f0c44358f3ee04ec3bff18cc6d4c0ed53ac8#diff-7ffa5adebc82192efdd4fa6c5bbc7af4e30cce9a8c1b7485565338b36e474436

If you find:

IncludesDialogVideoInfo.xml

And expand it with "load diff" and then search for "extendedinfo"

At line 1168 you'll see where all the actual "extendedinfo" stuff was removed:

                                <onclick condition="!System.HasAddon(script.extendedinfo)">RunPlugin(plugin://script.extendedinfo)</onclick>
                                <onclick condition="System.HasAddon(script.extendedinfo) + $EXP[IsMovieDBTypeNoFallback]">RunScript(script.extendedinfo,info=extendedinfo,dbid=$INFO[ListItem.DBID],name=$INFO[ListItem.Title])</onclick>
                                <onclick condition="System.HasAddon(script.extendedinfo) + $EXP[IsTvShowDBTypeNoFallback]">RunScript(script.extendedinfo,info=extendedtvinfo,dbid=$INFO[ListItem.DBID],name=$INFO[ListItem.TvShowTitle])</onclick>
                                <onclick condition="System.HasAddon(script.extendedinfo) + [String.IsEqual(ListItem.DBTYPE,season) | String.IsEqual(ListItem.Property(DBTYPE),season])">RunScript(script.extendedinfo,info=seasoninfo,tvshow=$INFO[ListItem.TvShowTitle],season=$INFO[ListItem.Season],silent=True)</onclick>
                                <onclick condition="System.HasAddon(script.extendedinfo) + $EXP[IsEpisodeDBTypeNoFallback]">RunScript(script.extendedinfo,info=extendedepisodeinfo,dbid=$INFO[ListItem.DBID],tvshow=$INFO[ListItem.TvShowTitle],season=$INFO[ListItem.Season],episode=$INFO[ListItem.Episode],silent=True)</onclick>

So what I would do is just add a 2nd button with the same onclic conditions as above.

minhgi commented 3 weeks ago

Replace button id=52 with the up above condition it stall load TheMovieDB Helper.

image image image