henryjfry / repository.thenewdiamond

9 stars 4 forks source link

[Feature Request] Any chance to add CSFD as autocompletion provider? #9

Closed horizon911 closed 1 year ago

horizon911 commented 2 years ago

Hi, Thanks for the addon updates! I wonder: Would there a possibility to have www.csfd.cz added as autocompletion provider? I found some reference to csfd autocompletion here... https://github.com/bartholomej/node-csfd-api/blob/master/tests/mocks/movie1.html.ts ...Not sure, if it's of any help.

Thanks! Horizon

henryjfry commented 2 years ago

Ok so I had a look at the site and it doesn't appear to have an official API. The link you provided appears to be a Java script app which can interact with the site? But I'm no good with Java script and the site is in polish so both those facts combined make it difficult to figure out where to begin.

If you can figure out how to trigger and return some of the functionality of node-csfd-api from within python then I could probably get it integrated.

But I poked around and couldn't figure it out myself.

horizon911 commented 2 years ago

Heyyyy, Thanks for looking into this! Hmmmm, it's all Greek to me.

If CSFD does not do the job, could TMDB or Trakt help? They do seem to offer APIs....

This is what I found:

  1. TMDB: 1https://python-tmdb3.readthedocs.io/_/downloads/en/latest/pdf/, 2https://www.themoviedb.org/talk/5522bb689251415c7f0060aa, 3https://stackoverflow.com/questions/57958733/how-do-i-put-an-autocomplete-based-on-api-request
  2. Trakt.Tv: https://trakt.docs.apiary.io/#

Regards Horizon


From: henryjfry @.> Sent: Sunday, February 13, 2022 10:19 AM To: henryjfry/repository.thenewdiamond @.> Cc: horizon911 @.>; Author @.> Subject: Re: [henryjfry/repository.thenewdiamond] [Feature Request] Any chance to add CSFD as autocompletion provider? (Issue #9)

Ok so I had a look at the site and it doesn't appear to have an official API. The link you provided appears to be a Java script app which can interact with the site? But I'm no good with Java script and the site is in polish so both those facts combined make it difficult to figure out where to begin.

If you can figure out how to trigger and return some of the functionality of node-csfd-api from within python then I could probably get it integrated.

But I poked around and couldn't figure it out myself.

— Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhenryjfry%2Frepository.thenewdiamond%2Fissues%2F9%23issuecomment-1037990069&data=04%7C01%7C%7C1eba180d69474e0ddeca08d9eeda48b7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637803443559053018%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2F33jcRx9tpLD9wqQQrepbfNQtyG0o3N2jmmO4o8h5CQ%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKQYA6WBRHPLAR6ZFSVR5ZLU26ASBANCNFSM5NQVTPAQ&data=04%7C01%7C%7C1eba180d69474e0ddeca08d9eeda48b7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637803443559053018%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Q%2F2nS4znKTt5%2FzSvGtue5DbWQeT0LOMGmO99Jm80Y7Y%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C1eba180d69474e0ddeca08d9eeda48b7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637803443559053018%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=j3GuTD99M1kxwdvsqTZX7H4WjKN73dLU7W4ngZ3Wk5U%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C1eba180d69474e0ddeca08d9eeda48b7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637803443559053018%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=7xVzMzB%2FUJPDumiA4zkS%2B4JsA4PAY2K5k7d185oIfAI%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

henryjfry commented 2 years ago

Well they do have APIs but they don't have anything like autocomplete I don't think. I updated the autocomplete parts in the repo as extendedinfo and skins connect to it. But I don't investigate the Google API call or the other provider(s) too much. However it's a continual search each time to type a new letter returning likely matches, getting results back from a non autocomplete API (tmdb for example) would provide no useful results, I think it only finds movies exactly matching what you type. Keywords are a little different but still wouldn't work for autocomplete.

I do think the autocomplete has language options and at least one other non Google provider. Amazon maybe? The only other one I can think that would likely work is IMDb, but they dont have any actual api either

horizon911 commented 2 years ago

Ah, I see. It seems to be much more complicated than I thought it would originally be. 😄

Both (as well as multisearch) might IMO return something useful.

But my biggest problem is that it does not seem to handle diacritics right, e.g.: https://www.themoviedb.org/search/multi?query=návště AND https://www.themoviedb.org/search/multi?query=navste ...should return the same results. But it does not, which breaks badly for me.

If I notice anything of the interest, I'll let you know. Thanks for everything! 🙂

Regards Horizon


From: henryjfry @.> Sent: Sunday, February 13, 2022 7:51 PM To: henryjfry/repository.thenewdiamond @.> Cc: horizon911 @.>; Author @.> Subject: Re: [henryjfry/repository.thenewdiamond] [Feature Request] Any chance to add CSFD as autocompletion provider? (Issue #9)

Well they do have APIs but they don't have anything like autocomplete I don't think. I updated the autocomplete parts in the repo as extendedinfo and skins connect to it. But I don't investigate the Google API call or the other provider(s) too much. However it's a continual search each time to type a new letter returning likely matches, getting results back from a non autocomplete API (tmdb for example) would provide no useful results, I think it only finds movies exactly matching what you type. Keywords are a little different but still wouldn't work for autocomplete.

I do think the autocomplete has language options and at least one other non Google provider. Amazon maybe? The only other one I can think that would likely work is IMDb, but they dont have any actual api either

— Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhenryjfry%2Frepository.thenewdiamond%2Fissues%2F9%23issuecomment-1038385460&data=04%7C01%7C%7Cf6995f8c7aa143d76fd508d9ef2a45c8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637803787111975339%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=WUIV0srirHinabOWFhDcw5nwquJAN0k5ymt02LfaXwo%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKQYA6TKXXA43MWMFMNL2YDU3ADVHANCNFSM5NQVTPAQ&data=04%7C01%7C%7Cf6995f8c7aa143d76fd508d9ef2a45c8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637803787111975339%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=cvZ%2BBd89wtJn1s0lmaO5IaZpddoAA0D%2Fzrcz%2FzF5%2B3Y%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Cf6995f8c7aa143d76fd508d9ef2a45c8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637803787111975339%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=K6dtZPkUiGwe7GgLkMSBxN8Ez1FTPAyhCPlhGkJXGYg%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7Cf6995f8c7aa143d76fd508d9ef2a45c8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637803787111975339%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=G0uqQRndS13zRZycFjuino2vk5WkBNl5MECq1%2FX%2FDeo%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>