henryju / protobuf-dt

Automatically exported from code.google.com/p/protobuf-dt
0 stars 0 forks source link

semicolon being ignored. #210

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Type the following line in a message:

  optional boolean show_legend = x|

That x is literally what I want. The | afterwards isn't part of it; it's just 
where the cursor is.

Press ";".

I expect the line to read

  optional boolean show_legend = x;

but it remains

  optional boolean show_legend = x|

and ignores my keypress.

Original issue reported on code.google.com by konigsb...@gmail.com on 5 Mar 2012 at 10:45

GoogleCodeExporter commented 9 years ago
Thanks Rob. I'll include a fix in the next release (v1.2.4)

Original comment by alr...@google.com on 7 Mar 2012 at 5:59

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago

Original comment by alr...@google.com on 7 Mar 2012 at 6:01

GoogleCodeExporter commented 9 years ago
Rob, out of curiosity, why would you like to have "x" as a field index. They 
are supposed to be a number.

(I will fix the bug, I'm just curious about your use case.)

Original comment by alr...@google.com on 8 Mar 2012 at 6:18

GoogleCodeExporter commented 9 years ago
I was not prepared to assign a number. I was just trying to get some framework 
of the new structure in place.

Original comment by konigsb...@gmail.com on 8 Mar 2012 at 6:23

GoogleCodeExporter commented 9 years ago
I see. Typing semicolon should work even with wrong input (e.g. "x"). I'll fix 
this bug shortly.

Original comment by alr...@google.com on 8 Mar 2012 at 7:05

GoogleCodeExporter commented 9 years ago
Fixed. Changes available at r5b3a78e51f7f

Original comment by alr...@google.com on 10 Mar 2012 at 9:36

GoogleCodeExporter commented 9 years ago
Rolling back change. It broke automatic generation of field indices

Original comment by alr...@google.com on 27 Mar 2012 at 7:24

GoogleCodeExporter commented 9 years ago
r6ae64f28f0ea

Original comment by alr...@google.com on 27 Mar 2012 at 7:31