henrylin03 / whats-the-weather

find out the weather anywhere around the world
http://henrylin.io/whats-the-weather/
MIT License
0 stars 0 forks source link

feat: a valid location name returns results in metric system #30

Closed henrylin03 closed 4 months ago

henrylin03 commented 4 months ago

fixes partially #1

note

at the moment, there is:

  1. no error handling in the DOM (eg if what the user enters gives no results), nor
  2. the scenario where the search yields multiple places (even a place like Sydney has multiple, like one in Canada).

These will also be part of a separate PR that will create the dropdown with those results and enable a user to pick which one they really mean OR if there are no results, tell that to the user. Completing that PR will complete #1

henrylin03 commented 4 months ago

this PR is already fairly large. I'm making the decision to take an iterative approach and merge this into main first, and then have a separate PR to build dropdown from the searchbar of all possible returned locations from the search and error if there isn't a location found (full scope of #1). that feature will be large and need to be broken down further. as such it will be separated.