search

henrynguyen6677 / df-frontend-2023

0 stars 0 forks source link

[assignment-3] Submission for assignment 3 #7

Open henrynguyen6677 opened 1 year ago

henrynguyen6677 commented 1 year ago

https://df-frontend-2023-am3.vercel.app/

chinhld12 commented 1 year ago

Hi @henrynguyen6677 , nice work!

Requirements

Final Result: ✅ passed

Feedback

  1. In many areas, types are still implemented loosely. E.g: https://github.com/henrynguyen6677/df-frontend-2023/blob/16cfc9bf92000d2aae0e964020ba90121b26bb9d/assignment-3/src/components/modals/add-book.modal.tsx#L11 https://github.com/henrynguyen6677/df-frontend-2023/blob/16cfc9bf92000d2aae0e964020ba90121b26bb9d/assignment-3/src/components/paging/paging.component.tsx#L22

You can try setting this config to true to see how many places are using implicit any: https://github.com/henrynguyen6677/df-frontend-2023/blob/16cfc9bf92000d2aae0e964020ba90121b26bb9d/assignment-3/tsconfig.json#L15

You should set this to "true" in your next assignment to improve how TypeScript addresses issues.

  1. Methods functions should be used with camelCase https://github.com/henrynguyen6677/df-frontend-2023/blob/16cfc9bf92000d2aae0e964020ba90121b26bb9d/assignment-3/src/utils/search.helper.ts#L1-L13